size_policy error

[dhruvbalwada]

We noticed today that the following error shows up when trying to use llcreader
TypeError: request() got an unexpected keyword argument 'size_policy'

The error can be reproduced quite simply as :

model = llcreader.ECCOPortalLLC4320Model()
model
ds_sst = model.get_dataset(varnames=['Theta'], k_levels=[0], type='latlon')

[rabernat]

This was fixed in #170. Update xmitgcm and fsspec.

[dhruvbalwada]

Just tried the updates on ocean pangeo, but still getting the same error.

Got the latest release of xmitgcm from github, and for fsspec pip install indicated that ocean pangeo was already on latest version.

[dhruvbalwada]

It is possible that the xmitgcm installation is not working. We do not get the error if we are executing the python commands for reading llc data while being inside the xmitgcm folder.

[rabernat]

The following works for me on ocean.pangeo.io:

import xmitgcm
from xmitgcm import llcreader
import fsspec
print(xmitgcm.__version__, fsspec.__version__)
# --> 0.4.1 0.5.2

model = llcreader.ECCOPortalLLC4320Model()
ds_sst = model.get_dataset(varnames=['Theta'], k_levels=[0], type='latlon')
ds_sst

edited to remove unnecessary NUMPY_EXPERIMENTAL_ARRAY_FUNCTION stuff...

[dhruvbalwada]

Still getting the same error (but it shows up when trying to plot something) :

[rabernat]

Ok good catch. ocean has xmitgcm v0.4.1. The changes introduced in #170 have not been released yet.

To get them, pip install git+https://github.com/MITgcm/xmitgcm.git. Then restart your kernel. That will fix your issue.

We should do a new release soon.

[dhruvbalwada]

Thanks, that worked now.
For some reason when I had cloned the latest version from github and ran setup.py it had not worked, maybe some update to the setup file is needed? Or maybe I was doing something stupid.