Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTBSession fails to select a proper Tunable when normalized_scores becomes None #176

Closed
pvk-developer opened this issue Feb 19, 2020 · 0 comments · Fixed by #178
Closed
Assignees
Milestone

Comments

@pvk-developer
Copy link
Collaborator

  • BTB version: 0.3.5
  • Python version: Python 3.6
  • Operating System: Ubuntu 18.04

Description

When we are runing BTBSession and there is a list of Tunables to try, once the max error is reached and self._normalized_scores becomes None, the BTBSession fails to select the proper Tunable.
This happens because we are doing a selection over the self._tuners list which is not updated after a Tunable is removed because of reaching max errors. In this case we have to use self._tunables in order to select from which one to continue tuning with. And if there is a case that this list is empty, then raise a StopTuning exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant