Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pipeline fitting after the last block with fit method #131

Closed
sarahmish opened this issue Jan 4, 2021 · 0 comments · Fixed by #132
Closed

Stop pipeline fitting after the last block with fit method #131

sarahmish opened this issue Jan 4, 2021 · 0 comments · Fixed by #132
Assignees
Labels
internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance
Milestone

Comments

@sarahmish
Copy link
Contributor

Right now, an MLPipeline produces the output of all primitives (blocks) within the pipeline (with the exception of the last primitive and designated output).

To save time, we can stop producing the output of blocks once we have reached the last block that can be fitted. To make these changes we can make the following changes:

  • figure out the last block that needs to be fitted in the pipeline and call it last_fit_block.
  • In L#780, check if the current block is after the last_fit_block. If true, then there is no need to produce the output of the current block.
if (block is before self._last_fit_block) or (block_name in output_blocks):
    self._produce_block(
        block, block_name, context, output_variables, outputs, debug_info)
@csala csala closed this as completed in #132 Jan 8, 2021
@csala csala added new feature internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance and removed new feature labels Jan 9, 2021
@csala csala added this to the 0.4.0 milestone Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal improvement This introduces no noticeable changes in the behavior but improves code quality and performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants