[pull] master from facebook:master #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: Changelog: [internal] `accessibilityElement.accessibilityFrame` returns CGRect in screen's coordinate space. Screen coordinate space changes whenever user scrolls. Therefore they have to be computed whenever on demand rather than precomputed. Reviewed By: mdvacca Differential Revision: D27118793 fbshipit-source-id: c48a2b9fc3f25b6ae797104371a2627193f4f79a
…ctionList] Remove defaultProps", Back out "[VirtualizedList] Remove keyExtractor defaultProps" Summary: Changelog: Partial revert the stack Reviewed By: makovkastar Differential Revision: D27156625 fbshipit-source-id: b158c9102047bb64ce708b200a8e5786f5a0c176
…f ElementProps Summary: Changelog: [Changed] Removed rest operator from ScrollViewStickyHeader props Reviewed By: lunaleaps Differential Revision: D27100507 fbshipit-source-id: 7d90ebeaf757bcaed0b125a4a8abf44f07adf98f
Summary: This diff splits up the LTR and RTL examples in RNTester for Horizontal ScrollView into two examples for ease of E2E testing. Changelog: [Changed] Split RTL and LTR Horizontal ScrollView tests in RNTester into two tests Reviewed By: lunaleaps Differential Revision: D27139885 fbshipit-source-id: aae8aa06f4827507d1bc26a6b173d39cc92e20fe
Summary: The sampling heap profiler will need to be enable-able by the inspector, and the previous snapshot/profiling APIs are all defined on `jsi::instrumentation`. Follow their lead and define the new sampling heap profiler APIs on `jsi::instrumentation` as well, and implement it for Hermes. Changelog: [Internal] Reviewed By: neildhar Differential Revision: D26835152 fbshipit-source-id: 4625be3214297489e04a4ceea8a22622d14299c4
Summary: In the Chrome inspector, add support for `HeapProfiler.startSampling` and `HeapProfiler.stopSampling`. These two protocols turn the sampling heap profiler on and off, and write the results on the socket. Then Chrome's visualizer pieces the information together to produce a flame graph of memory usage. Added a unit test to make sure sampling can be turned on and off, and there are some samples returned. Changelog: [Internal] Reviewed By: avp Differential Revision: D26835148 fbshipit-source-id: d1be3cee791e42da5d9e117c3b8259b6622b98f4
Summary: Changelog: [General][Changed] - Updated SectionList example in RNTester Lists need an explicit height set, otherwise their intrinsic height is the height of the root view. This causes rendering issues as shown in the test plan. Additionally, refactored to allow visibilityConfig to be passed as prop for future tests. Reviewed By: kacieb Differential Revision: D27098086 fbshipit-source-id: b19155de79d00dddc287a1e2f9cdb240f2f31e27
Summary: # Changelog: [Internal][Added] - Provide more props to SectionList examples Reviewed By: kacieb Differential Revision: D27100891 fbshipit-source-id: 10e83ca16badf18e8218557aff1ee8a7a86e8c54
Summary: # Changelog: [General][Added] - Added more RNTester examples for FlatList as similar to SectionListExamples. Reviewed By: kacieb Differential Revision: D27104601 fbshipit-source-id: 0a2cb24382d42956bacf455fd0a699adb61c7c83
Summary: Changelog: [Fixed] Fix typo in sendAccessibilityEvent in AccessibilityExample.js Reviewed By: mdvacca Differential Revision: D27160274 fbshipit-source-id: eee0a6cefa559b29ed73890abff3a44dacb19b62
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )