-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make coastal refined meshes produced with JGSAW BFB between runs #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This is exactly what we discussed.
@mark-petersen and @pwolfram, again, a quick review by inspection is what is needed here. Once we get this onto |
@xylar, If there were reproducibility issues with generating EC60to30, we may need to look into that further. That mesh does not use my coastal_tools.py to produce the resolution distribution input for JIGSAW, it's just specified by a latitude-dependent function. MPAS-Model/testing_and_setup/compass/ocean/global_ocean/EC60to30/init/define_base_mesh.py Lines 13 to 20 in 0040864
|
I'll test it right now. |
I found that the JIGSAW EC60to30 case is BFB between runs. |
@sbrus89, as we discussed in person, we suspect that the reproducibility issues with the EC60to30 mesh are likely to do with @mark-petersen running on two different machines (grizzly and badger) with two different compilations of JIGSAW (perhaps different versions). |
The reproducibility issues are likely going to be diminished by using a common version of JIGSAW from conda in the future but for now we probably need to document details like which machine was used, which modules (and versions) were loaded and which JIGSAW hashtag was used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve by visual inspection. Like @xylar said, I ran on two different machines before. If you get bfb reproducibility with this change, that's a great confirmation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks for fixing @sbrus89!
Thanks @xylar, @mark-petersen for help in sorting this out.
Make coastal refined meshes produced with JGSAW BFB between runs This PR fixes the consistency issues observed when producing coastal refined meshes (issue MPAS-Dev#178). The cause was not setting the random seed used in the approximate nearest neighbor library (pyflann). This led to varying resolution specification inputs going into JIGSAW each time the COMPASS workflow was run. Setting the random seed to the same specified value resolves the issue.
TestingI tested the nightly regression suite on badger with GNU and this branch is bit-for-bit identical to the current |
Make coastal refined meshes produced with JGSAW BFB between runs This PR fixes the consistency issues observed when producing coastal refined meshes (issue MPAS-Dev#178). The cause was not setting the random seed used in the approximate nearest neighbor library (pyflann). This led to varying resolution specification inputs going into JIGSAW each time the COMPASS workflow was run. Setting the random seed to the same specified value resolves the issue.
This PR fixes the consistency issues observed when producing coastal refined meshes (issue #178). The cause was not setting the random seed used in the approximate nearest neighbor library (pyflann). This led to varying resolution specification inputs going into JIGSAW each time the COMPASS workflow was run. Setting the random seed to the same specified value resolves the issue.
closes #178