-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create mask and mapping files for online MOC and MPAS-Analysis #468
Create mask and mapping files for online MOC and MPAS-Analysis #468
Conversation
TestingOn my laptop, I have run the
The masks are created as expected. For example:
Update:
Further testing is needed to make sure the resulting files actually work as expected in MPAS-Analysis. The online MOC analysis member will also need to be tested, and may require changes (in particular with the new file name that includes 4 regional MOC basins, not just the Atlantic). |
c31341b
to
a44f8fc
Compare
@milenaveneziani and @darincomeau, don't worry about reviewing this just yet. At some point, I might ask you to perform an MPAS-Analysis run with the masks and mapping files created by @mark-petersen, your feedback would be appreciated anytime, since you're familiar with the code I'm altering. |
@xylar: would it make sense to add a section for making Arctic regions? I can add it, since I know the different region groups I created. |
@milenaveneziani , sure, feel free. |
@milenaveneziani, if you just want to give me a list of regions, I'll be happy to add it, too. |
Hi @xylar, thanks for offering. I seem to understand that you need the full list of regions, not just the group or tag name, right? |
@milenaveneziani, a tag would be okay. |
A tag is fine. I have added a 'Arctic' tag to regions of the Arctic_Basin and Atlantic_Basin (two other tags) that are relevant to the Arctic and sub-Arctic (such as the Canada Basin and the Labrador Sea). So the 'Arctic' regions would be great to add a this point. There is also another parallel category, that @proteanplanet (Andrew) requested for comparisons with sea-ice observations, and that is called 'Arctic_NSIDC'. We can add this later if necessary. |
Here is the list of regions associated with the 'Arctic' tag: |
ooh, that was nice and quick. thanks. I will start a test soon. |
I tested the Arctic regions on the QU240 grid. I get masks for these regions:
Looks the same as your list. |
oops, wait, now I understand why you say we should wait about testing.. This is something that comes during the init step. |
Right, this is for generating new meshes, so that's the stage at which it's worth testing. Presumably once @mark-petersen has got enough of these features on a branch for testing, we'll run one of the test cases through the paces all the way to analysis. |
Remove some trailing white space.
This way, we make the geojson file on the fly rather than having to symlink to it. We also use the new southern transect that is the true southern boundary of each MOC region, rather than the approximate transect from previously.
This merge adds functionality for creating antartics- region, ocean-basin, ice-shelf and transport-transect masks.
For runs with ice-shelf cavities, the E3SM initial condition needs to come at least after ssh adjustment. All initial conditions should probably come after spin-up as well.
6b0b381
to
cc114b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran QU240/init/e3sm_coupling
and everything in transects_and_regions
was created successfully. We can fine-tune after this glob of PRs is merged in.
…evelop This merge adds functionality for creating MOC, Antarctic-region, ocean-basin, ice-shelf and transport-transect masks using `mpas_tools` and `geometric_features`. It does not require any pre-cached files other than those already part of `geometric_features` (which now includes all the geometric data when it is installed as part of the `compass` conda environment). Mapping files between the mesh and the default comparison grids in MPAS-Analysis are now also created and staged for uploading. This merge also performs some clean-up: * Fixes a typo in `ocean_initial_state` * Removes trailing white space and performs some other PEP8 clean-up * (mostly 2 new lines between functions) * Points to the initial condition from `ssh_adjustment` rather than * `initial_state` for test cases with ice-shelf cavities. (This should * eventually point to the last restart file from spin-up for most runs, * so this is only an intermediate fix.)
…evelop This merge adds functionality for creating MOC, Antarctic-region, ocean-basin, ice-shelf and transport-transect masks using `mpas_tools` and `geometric_features`. It does not require any pre-cached files other than those already part of `geometric_features` (which now includes all the geometric data when it is installed as part of the `compass` conda environment). Mapping files between the mesh and the default comparison grids in MPAS-Analysis are now also created and staged for uploading. This merge also performs some clean-up: * Fixes a typo in `ocean_initial_state` * Removes trailing white space and performs some other PEP8 clean-up * (mostly 2 new lines between functions) * Points to the initial condition from `ssh_adjustment` rather than * `initial_state` for test cases with ice-shelf cavities. (This should * eventually point to the last restart file from spin-up for most runs, * so this is only an intermediate fix.)
This merge adds functionality for creating MOC, Antarctic-region, ocean-basin, ice-shelf and transport-transect masks using
mpas_tools
andgeometric_features
. It does not require any pre-cached files other than those already part ofgeometric_features
(which now includes all the geometric data when it is installed as part of thecompass
conda environment).Mapping files between the mesh and the default comparison grids in MPAS-Analysis are now also created and staged for uploading.
This merge also performs some clean-up:
ocean_initial_state
ssh_adjustment
rather thaninitial_state
for test cases with ice-shelf cavities. (This should eventually point to the last restart file from spin-up for most runs, so this is only an intermediate fix.)