Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Base unit from k$\lambda$ to $\lambda$ #249

Merged
merged 25 commits into from
Jan 5, 2024
Merged

Change Base unit from k$\lambda$ to $\lambda$ #249

merged 25 commits into from
Jan 5, 2024

Conversation

iancze
Copy link
Collaborator

@iancze iancze commented Dec 30, 2023

Feature branch to convert base unit from k $\lambda$ to $\lambda$.

When merged into main,

  • Standardized nomenclature of {class}mpol.coordinates.GridCoords and {class}mpol.fourier.FourierCube to use sky_cube for a normal image and ground_cube for a normal visibility cube (rather than sky_ for visibility quantities). Routines use packed_cube instead of cube internally to be clear when packed format is preferred.
  • Modified {class}mpol.coordinates.GridCoords object to use cached properties #187.
  • Changed the base spatial frequency unit from k$\lambda$ to $\lambda$, addressing #223. This will affect most users data-reading routines!

@iancze iancze marked this pull request as ready for review January 5, 2024 12:37
@iancze iancze merged commit 84e1b7d into WIP-v0.3 Jan 5, 2024
3 checks passed
@iancze iancze deleted the base-unit branch January 5, 2024 12:37
@iancze iancze mentioned this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants