Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date settings in analyses are parsed as floats for certain locales #67

Closed
crnh opened this issue Mar 7, 2024 · 2 comments · Fixed by #70
Closed

Date settings in analyses are parsed as floats for certain locales #67

crnh opened this issue Mar 7, 2024 · 2 comments · Fixed by #70
Assignees
Labels
bug Something isn't working

Comments

@crnh
Copy link
Collaborator

crnh commented Mar 7, 2024

See this issue: #66 (comment)
Some locales use dots as date separators. The regexes used in some analyses confuse these dates for numbers and try to parse them as floats. This is the case for zospy.analyses.zernike_standard_coefficients but probably also for other analyses.

@crnh
Copy link
Collaborator Author

crnh commented Mar 7, 2024

As we are working on new, more robust analysis parsers, this issue has a low priority. We might release a temporary fix it it is not too much work.

@crnh crnh self-assigned this Mar 7, 2024
@crnh crnh added the bug Something isn't working label Mar 7, 2024
@crnh
Copy link
Collaborator Author

crnh commented Mar 7, 2024

I ran the unit tests on a system with a German locale and found this problem to only occur in zospy.analyses.zernike_standard_coefficients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant