Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp2response speedup #1406

Merged
merged 2 commits into from Jul 31, 2018
Merged

amp2response speedup #1406

merged 2 commits into from Jul 31, 2018

Conversation

Lestropie
Copy link
Member

Pre-allocate memory for ZSH transformations and image data, rather than using Eigen's conservativeResize() function. According to a user, their dwi2response call went from 40 minutes to 8.

Also should fix the segfault on providing an XxYxZx1 mask image as reported in #1231.

Closes #1231.

Pre-allocate memory for ZSH transformations and image data, rather than using Eigen's conservativeResize() function.
Closes #1231.
@jdtournier
Copy link
Member

According to a user, their dwi2response call went from 40 minutes to 8.

😮

Guess we need to fix the testing first though... I'll work on that today.

@jdtournier
Copy link
Member

Let's see if the recent merge of #1393 will help with the testing here...

In the meantime, any chance you could take me through the maths behind amp2response? Maybe they're already described in some other issue? I'm just surprised it would still take 8 minutes - I reckon there's scope for some further optimisation, but I'd like to get a better feel for what you're trying to do before suggesting something daft...

@Lestropie
Copy link
Member Author

That timing would have been for dwi2response as a whole, not just amp2response.

Re-acquired some HCP data to check it myself: dwi2response dhollander was 2:40 on dev, 2:10 on this branch. Guessing that if the system starts swapping at all the difference will be more drastic.

Also confirm that this worked with a XxYxZx1 mask image, whereas dev segfaulted; should push that to master as well I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants