Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp2response performance #1231

Closed
Lestropie opened this issue Jan 16, 2018 · 1 comment
Closed

amp2response performance #1231

Lestropie opened this issue Jan 16, 2018 · 1 comment
Assignees

Comments

@Lestropie
Copy link
Member

As raised here (even though there's an upstream problem in that particular case).

  • Don't bother constructing transformation matrices when using the -isotropic option.

  • Pre-determine the number of voxels in the mask, and pre-allocate cat_transforms and cat_data rather than using conservativeResize().

@thijsdhollander
Copy link
Contributor

While this sits here, just adding something I forgot to create an issue for, but stumbled upon at some point: if I remember well, amp2response crashes (segfault) when the provided mask (i.e. second argument) is 4-dimensional, even with the size of the 4th dimension being "1" (so the mask essentially being 3D).

Lestropie added a commit that referenced this issue Jul 17, 2018
Pre-allocate memory for ZSH transformations and image data, rather than using Eigen's conservativeResize() function.
Closes #1231.
@Lestropie Lestropie self-assigned this Jul 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants