Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

foreach rename to for_each #1922

Merged
merged 1 commit into from Jan 29, 2020
Merged

foreach rename to for_each #1922

merged 1 commit into from Jan 29, 2020

Conversation

maxpietsch
Copy link
Member

rename foreach as it is a shell reserved word in zsh #1708

@Lestropie Lestropie self-requested a review January 29, 2020 01:15
Lestropie
Lestropie approved these changes Jan 29, 2020
View reviewed changes
Copy link
Member

@Lestropie Lestropie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in #1708 I'm content with this solution.

@jdtournier
Copy link
Member

Happy too.

@jdtournier jdtournier merged commit f7397a1 into dev Jan 29, 2020
@jdtournier jdtournier deleted the foreach_rename branch January 29, 2020 16:56
Lestropie added a commit that referenced this pull request Apr 22, 2020
@Lestropie
for_each: Tests obey command rename #1922
8aa04aa 
Note that location of test data directory has not yet been modified.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lestropie Lestropie Lestropie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxpietsch @jdtournier @Lestropie