Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to installation documentation #2049

Merged
merged 19 commits into from
Jun 10, 2020
Merged

Updates to installation documentation #2049

merged 19 commits into from
Jun 10, 2020

Conversation

jdtournier
Copy link
Member

As discussed recently - preview here. I think this addresses everything that we'd talked about, other than the latter half of this specific point:

  • May want to include explicit statement about Python3 being preferable but that depending on the distro there is a chance of Python2 being inadvertently pulled in

I'm not sure we need to go into this amount of detail, especially in light of #2047...

@jdtournier jdtournier requested a review from a team May 7, 2020 15:20
@jdtournier jdtournier self-assigned this May 7, 2020
@Lestropie
Copy link
Member

Made a few tweaks; I went easy on the Python side of things as I think that's better addressed as a standalone PR along with addressing #2047.

@jdtournier
Copy link
Member Author

OK, happy with that, thanks @maxpietsch. Do you want to approve the PR so we can merge it?

@maxpietsch
Copy link
Member

All good as far as I can tell. I only changed Apple Store to App Store and added a link that on macOS allows opening Xcode in the App Store.

@jdtournier jdtournier merged commit 5b4aef8 into master Jun 10, 2020
@jdtournier jdtournier deleted the doctest branch June 10, 2020 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants