Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for subset handling -> display ID updates #137

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Conversation

shouples
Copy link
Collaborator

@shouples shouples commented Dec 14, 2022

Lingering issue after #135 was that jumping to different cell executions and same-dataset rendering would mix up display IDs.

The simplest solution is to just pop the hash out of the subset cache so the only time we add data is during a resampling event, which means the only time it's going to be checked is immediately after an update_display_id() call when format() is being called. Once that update process is done, we pop the hash out, and no follow-on confusion happens.

Extra: minor metadata updates to handle subsets pulling parent metadata to include resample filters.

@shouples shouples self-assigned this Dec 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #137 (85e9894) into main (c516580) will decrease coverage by 0.03%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   80.13%   80.09%   -0.04%     
==========================================
  Files          48       48              
  Lines        2436     2442       +6     
==========================================
+ Hits         1952     1956       +4     
- Misses        484      486       +2     
Impacted Files Coverage Δ
src/dx/plotting/dashboards.py 22.22% <0.00%> (ø)
src/dx/plotting/dex/basic.py 21.42% <0.00%> (ø)
src/dx/plotting/main.py 26.31% <0.00%> (ø)
src/dx/formatters/main.py 83.33% <57.14%> (-1.14%) ⬇️
src/dx/utils/formatting.py 87.11% <85.71%> (ø)
src/dx/filtering.py 100.00% <100.00%> (ø)
src/dx/types/dex_metadata.py 94.08% <100.00%> (ø)
src/dx/utils/tracking.py 95.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e75b65...85e9894. Read the comment docs.

@shouples shouples merged commit 0360669 into main Dec 14, 2022
@shouples shouples deleted the djs/subset-handling-fix branch December 14, 2022 18:27
shouples added a commit that referenced this pull request Jan 6, 2023
* clear hash from SUBSET_HASH_TO_PARENT_DATA during update formatting

* info->debug logging & general logging updates

* fix for filter attribute error; logging updates

* fix filter types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants