Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carnatic sloppy code #142

Open
7 tasks
alastair opened this issue May 15, 2014 · 0 comments
Open
7 tasks

Fix carnatic sloppy code #142

alastair opened this issue May 15, 2014 · 0 comments
Milestone

Comments

@alastair
Copy link
Member

Lots of code was written quickly for the carnatic release. It works, but some of it is messy and there's lots of duplicated code that can be cleaned up.

Some places to start:

  • main view search/filtering
  • Code in carnatic models that should be shared in data with hindustani
  • Hard-coding of carnatic specific items in the data module (e.g. the word concert)
  • similar functions that do almost the same thing but are duplicated instead of having an argument
  • Duplicate code in templates that should be split into {% include %}s
  • Duplicate templatetags for carnatic and hindustani, but needing to name them different things
  • Tests
@alastair alastair added this to the Carnatic milestone May 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant