-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pending python 3 upgrade tasks #111
Comments
This doesn't work in python3, as pickle.load requires bytes, but sys.stdin is a string. Ideally this would be fixed by #96, allowing us to remove cluster mode, but in the meantime we should work out a solution to this specific problem. |
In python 3,
when I run this script multiple times, it doesn't skip already done jobs as it does in python 2:
Running the same script multiple types in the same docker container results in different hashes each time. There is a random seed set in the project file. I've replaced it with |
Running in python 3, clustermode=False, after about 290 jobs I get an exception
This has happened more than once. Is something not cleaning up properly? Maybe a difference between concurrent.futures in python 3.6 and the backport we use in python 2? |
✔️ This item is fixed in #115
There is still some python code which only runs in python 2.
Most importantly are uses of basestring and unicode:
gaia/src/bindings/pythonic.i
Lines 24 to 31 in ed433ed
These will have to be converted, but we have to understand the use of the types in this method. Theoretically both basestring and unicode can be changed to
str
, but in python 3, we should double-check where items should be actual strings, and where they should be encoded bytes.The text was updated successfully, but these errors were encountered: