-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding features #30
Adding features #30
Conversation
Sorry for the lack of reaction - been pretty busy. |
I do not know GIT well enough to figure out how to merge it when there are changes on both sides. |
I have tried resolving this for you - please check if it still works as intended. And for another time, please create a new branch and merge from that. I think your issue lies burried there. |
Just made a test run myself, and this PR is loaded with errors. |
Lets try to finally get the two versions merged together, before they get too different.
I see you have updated pydanfossally to version 0.0.27 that is compatible with my changes.
So, I now use it from there and it seems to be working fine.
Changes are as follows:
Reading and writing setpoints using: manual_mode_fast, at_home_setting, leaving_home_setting, pause_setting, holiday_setting depending on the preset mode, rather than using temp_set as before.
Holiday preset mode added.
Quicker reaction to changes performed in the UI
Added floor temperature sensor
Fix for setmode issue
Added action and service call to set target temperature for a specific preset mode.
Preset mode is optional, and writes to current preset mode when not specified.
Added an indication for 'banner control' (local override).
When setpoint is changed locally from the thermostat it raises this flag and uses this as manual target setpoint.