Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements mostly from jnxxx #43

Merged
merged 20 commits into from
Oct 24, 2022
Merged

Improvements mostly from jnxxx #43

merged 20 commits into from
Oct 24, 2022

Conversation

tbarnekov
Copy link
Contributor

@tbarnekov tbarnekov commented Oct 22, 2022

I've taken the liberty of merging the improvements from @jnxxx (previously attempted in PR #30). I believe I've fixed all the conflicts and also a few minor issues.

I've blatantly stolen most of the original description from #30

Overall changes are as follows:

Reading and writing setpoints using: manual_mode_fast, at_home_setting, leaving_home_setting, pause_setting, holiday_setting depending on the preset mode, rather than using temp_set as before.
It seems to work, so far.

Holiday preset modes added (home and away).

Quicker reaction to changes performed in the UI

Added floor temperature sensor

Fix for setmode issue

Added action and service call to set target temperature for a specific preset mode.
Preset mode is optional, and writes to current preset mode when not specified.

Added an indication for 'banner control' (local override).
When setpoint is changed locally from the thermostat it raises this flag and uses this as manual target setpoint.

conorsham and others added 20 commits May 17, 2022 00:08
Fix wrong representation of working state (Heating/Idle) for Icon RT

Thanks @tbarnekov

Sorry for the delay, but I have been hung up on work.
Additionally my repo was quite unrecognizable after MTrab had attempted to fix it, to merge with the original one.

I got the Danfoss firmware update yesterday, and noticed Icon now reports working_state but inverted for the same reason as you found.
Nice you had already made a fix for it.

Repo is rolled back, fix appears to work....
Merging it in.
# Conflicts:
#	README.md
#	custom_components/danfoss_ally/__init__.py
#	custom_components/danfoss_ally/binary_sensor.py
#	custom_components/danfoss_ally/climate.py
#	custom_components/danfoss_ally/sensor.py
@MTrab MTrab added the enhancement Enhancement of the integration label Oct 24, 2022
@MTrab
Copy link
Owner

MTrab commented Oct 24, 2022

Thank you :)

@MTrab MTrab merged commit e6d83fc into MTrab:master Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants