-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements mostly from jnxxx #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix wrong representation of working state (Heating/Idle) for Icon RT Thanks @tbarnekov Sorry for the delay, but I have been hung up on work. Additionally my repo was quite unrecognizable after MTrab had attempted to fix it, to merge with the original one. I got the Danfoss firmware update yesterday, and noticed Icon now reports working_state but inverted for the same reason as you found. Nice you had already made a fix for it. Repo is rolled back, fix appears to work.... Merging it in.
# Conflicts: # README.md # custom_components/danfoss_ally/__init__.py # custom_components/danfoss_ally/binary_sensor.py # custom_components/danfoss_ally/climate.py # custom_components/danfoss_ally/sensor.py
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken the liberty of merging the improvements from @jnxxx (previously attempted in PR #30). I believe I've fixed all the conflicts and also a few minor issues.
I've blatantly stolen most of the original description from #30
Overall changes are as follows: