-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The error message produced when providing an invalid averaging value could be clearer #133
Comments
This was because the match result {
Err(e) => {
eprintln!("preprocessing error: {e}")
}
} which only showed the error type, and not the detailed error info and line number. now that it's printed with debug "{e:?}", the original error message has been restored.
|
I think printing the debug representation of the error is not what you want. It might make this particular error look OK, but most other errors will not be human readable (e.g. 35e4cba). This is why it's called a debug rep - it's meant to be for programmers, not humans. I therefore think that it would be best to change the |
I agree that this would be a better solution long term, but I think including the error messages with line numbers provides a substantial improvement over just the name of the error for now. How about I open up a new ticket for this. |
error looks like this now
|
This is a placeholder so that I don't forget.
An invalid averaging value was provided through asvo, and the error message just said something like "error parsing cli", but not which specific argument was at fault.
The text was updated successfully, but these errors were encountered: