Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited state is no longer visible in 0.7.4 #890

Closed
sanderaarts opened this issue Mar 19, 2019 · 10 comments
Closed

Edited state is no longer visible in 0.7.4 #890

sanderaarts opened this issue Mar 19, 2019 · 10 comments
Labels
Bug Help Wanted! Issue not reproduceable. Addional info or help is required
Milestone

Comments

@sanderaarts
Copy link

Describe the bug
In previous versions when the db was changed 'Edited' was shown in the title bar (on macOs at least) until the changes were saved. That's no longer the case.

To Reproduce
Steps to reproduce the behavior:

  1. Add new entry, but do not save yet.
  2. There's no indication the db was changed (on macOs it used to show 'Edited' right after the db name in the title bar).

Expected behavior
A visible indication that there are unsaved changed.

Desktop (please complete the following information):

  • macOS: 10.14.3
  • Version 0.7.4
@mstarke
Copy link
Member

mstarke commented Mar 19, 2019

I am unable to reproduce this error. For me the behaviour is exactly as expected. See attached file.

EditedState

@georgesnow
Copy link
Contributor

i tested as well on 0.7.4 macOS 10.14.3. and i am seeing edited

Screen Shot 2019-03-19 at 9 53 36 AM

@mstarke mstarke added this to the 0.7.5 milestone Mar 19, 2019
@mstarke mstarke added Help Wanted! Issue not reproduceable. Addional info or help is required Bug labels Mar 19, 2019
@sanderaarts
Copy link
Author

I just noticed it works on some dbs but not all. I have two dbs, both on the same server. I have full access one that does show the 'edited' string and read/write access on the one that doesn't.

As far as I remember it used to work on both. And I would expect that read/write access should be enough for this feature to work.

@mstarke
Copy link
Member

mstarke commented Mar 19, 2019

Can you specify your setup a bit more so I might be able to pin this down?

@sanderaarts
Copy link
Author

macOS: 10.14.3
Version 0.7.4
2 dbs on same server, connected over smb:
db1.kdbx (read/write access, unlocking with keyfile): no edited state is shown
db2.kdbx (full access, db created by myself, unlocking with password): edited state is shown

I've also created another db on the same server to test whether the type of unlocking makes a difference, but that doesn't seem to be the case:
test.kdbx (full access, unlocking with same keyfile): edited state is shown

@mstarke
Copy link
Member

mstarke commented Mar 19, 2019

Can you try to create the same setup with text files with TextEdit and see what happens? If the same behaviour is present this might be an macOS bug.

@mstarke
Copy link
Member

mstarke commented Mar 19, 2019

This issue seems to be related to search! See 0.7.5. release notes

@mstarke
Copy link
Member

mstarke commented Mar 19, 2019

@sanderaarts can you try out 0.7.5 and see if the release fixes the issue?

@mstarke mstarke modified the milestones: 0.7.6, 0.7.5 Mar 19, 2019
@sanderaarts
Copy link
Author

@mstarke It seems to work for both dbs again in 0.7.5. Thx!

@mstarke
Copy link
Member

mstarke commented Mar 21, 2019

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Help Wanted! Issue not reproduceable. Addional info or help is required
Projects
None yet
Development

No branches or pull requests

3 participants