Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't set ComboBox buttons width with ControlsHelper.ButtonWidth #2352

Closed
iSlaffko opened this issue Feb 15, 2016 · 1 comment · Fixed by #2365
Closed

Can't set ComboBox buttons width with ControlsHelper.ButtonWidth #2352

iSlaffko opened this issue Feb 15, 2016 · 1 comment · Fixed by #2365
Assignees
Milestone

Comments

@iSlaffko
Copy link

If you set a height of a ComboBox to a larger number than a default one, you may see, that buttons (two with editable ComboBox) take a lot of space comared to other similar controls. Here is an example of ridiculously tall ComboBox in demonstrational purpose (note: ClearTextButton is pressed):

image

If I understood it right, buttons' shape is set to be square in ComboBox XAML:

<ColumnDefinition Width="{Binding RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type Grid}}, Path=ActualHeight, Mode=OneWay}" />

I'd like to have the ability to set buttons' width using Controls:ControlsHelper.ButtonWidth="22" as it is allowed in TextBox

<ColumnDefinition x:Name="ButtonColumn" Width="Auto" />
...
<Button x:Name="PART_ClearText"
    Width="{Binding RelativeSource={RelativeSource TemplatedParent}, Path=(Controls:ControlsHelper.ButtonWidth), Mode=OneWay}"
...

What I'd like to have in a case of such a huge control is:

image

@punker76 punker76 added this to the 1.3.0 milestone Feb 15, 2016
@punker76 punker76 self-assigned this Feb 15, 2016
@punker76
Copy link
Member

@iSlaffko just saw this on TextBox too and I'd also say that ButtonWidth should be respect...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants