New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HamburgerMenuItem Scrolling #2857

Closed
amkuchta opened this Issue Feb 16, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@amkuchta
Contributor

amkuchta commented Feb 16, 2017

What steps will reproduce this issue?

If the window is sized to be smaller than the height of the HamburgerMenu, OptionsListView overlaps ButtonsListView

Expected outcome

Ideally, the PaneRoot would not be allowed to have a height smaller than is required to show all of the items in the pane. My suggestion is to use a DockPanel wrapped in a ScrollViewer to host the ListBox controls, shown below:

<ScrollViewer VerticalAlignment="Stretch">
  <DockPanel VerticalAlignment="Stretch">
    <ListBox x:Name="ButtonsListView" DockPanel.Dock="Top" VerticalAlignment="Top">
      <ListBoxItem ... />
      <ListBoxItem ... />
      <ListBoxItem  ... />
    </ListBox >
    <ListBox x:Name="OptionsListView" DockPanel.Dock="Bottom" VerticalAlignment="Bottom">
      <ListBoxItem  ... />
      <ListBoxItem ... />
      <ListBoxItem  ... />
    </ListBox >
  </DockPanel>
</ScrollViewer>

Repo

https://github.com/amkuchta/Vulnerator/tree/code_cleanup

Environment

  • MahApps.Metro v1.4.3
  • Windows OS 7 & 10
  • Visual Studio 2015
  • .NET Framework 4.5.2
@punker76

This comment has been minimized.

Show comment
Hide comment
@punker76

punker76 Feb 16, 2017

Member

@amkuchta I think the options menu of a HamburgerMenu should not have too many items, so it can be always visible and overlap the normal menu items. The scrollbar of normal menu item listbox is shown if there are many items. So IMO we should leave this as it is (and how it works in the UWP Community Toolkit). If you need other implementation you can create your own HamburgerMenu style with your specifications.

Member

punker76 commented Feb 16, 2017

@amkuchta I think the options menu of a HamburgerMenu should not have too many items, so it can be always visible and overlap the normal menu items. The scrollbar of normal menu item listbox is shown if there are many items. So IMO we should leave this as it is (and how it works in the UWP Community Toolkit). If you need other implementation you can create your own HamburgerMenu style with your specifications.

@amkuchta

This comment has been minimized.

Show comment
Hide comment
@amkuchta

amkuchta Feb 16, 2017

Contributor

@punker76 I'll look into rolling my own. I am gonna look into opening a similar issue on the UWP Toolkit Community repository as well - I don't see why the options menu takes precedence over the normal menu items. I also think that the VerticalScrollBar should be on the left instead of the right so that it is always visible when the lists are too long... but that is just me being picky

Contributor

amkuchta commented Feb 16, 2017

@punker76 I'll look into rolling my own. I am gonna look into opening a similar issue on the UWP Toolkit Community repository as well - I don't see why the options menu takes precedence over the normal menu items. I also think that the VerticalScrollBar should be on the left instead of the right so that it is always visible when the lists are too long... but that is just me being picky

@amkuchta

This comment has been minimized.

Show comment
Hide comment
@amkuchta

amkuchta Feb 17, 2017

Contributor

@punker76 I just did a PR for the UWP Community Toolkit to correct this - would you like me to apply the same fix here?

Contributor

amkuchta commented Feb 17, 2017

@punker76 I just did a PR for the UWP Community Toolkit to correct this - would you like me to apply the same fix here?

@amkuchta

This comment has been minimized.

Show comment
Hide comment
@amkuchta

amkuchta Mar 6, 2017

Contributor

@punker76 poke 👉

Contributor

amkuchta commented Mar 6, 2017

@punker76 poke 👉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment