Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all Angular Components and Services #2318

Closed
shaman-apprentice opened this issue Jul 27, 2021 · 1 comment
Closed

Migrate all Angular Components and Services #2318

shaman-apprentice opened this issue Jul 27, 2021 · 1 comment

Comments

@shaman-apprentice
Copy link
Contributor

shaman-apprentice commented Jul 27, 2021

This is a living todo list. Feel free to resort or add items to it. If you start with an item please move it to the top and add your name behind it. If necessary, we can discuss in the comments section further steps or create further tickets.

Clean up tasks:

  • Refactor custom dispatch / integrate NgRx (all AngularJS dependencies can be removed without replacing redux through NgRx)
  • Remove AngularJS dependencies (@shaman-apprentice )
  • check ngAfterViewChecked of rangeSliderLabels.component.ts (@shaman-apprentice )
  • improve test in app\codeCharta\ui\ribbonBar\colorSettingsPanel\colorSettingsPanel.component.spec.ts (see comments there) (@shaman-apprentice )
ngormsen added a commit that referenced this issue Jul 30, 2021
shaman-apprentice added a commit that referenced this issue Aug 2, 2021
which makes custom handling in threeSceneService deprecated. Having only one global state and flow is more maintanable in general and in concrete it facilitates migrating to Angular.

refs: #2318
shaman-apprentice added a commit that referenced this issue Aug 2, 2021
Missing:
- tests for component
- test for including `this` in mapStateToThis
- return type of connect if mapDispatchtoThis is not given

refs: #2318
shaman-apprentice added a commit that referenced this issue Aug 4, 2021
which makes custom handling in threeSceneService deprecated. Having only one global state and flow is more maintanable in general and in concrete it facilitates migrating to Angular.

refs: #2318
shaman-apprentice added a commit that referenced this issue Aug 4, 2021
Missing:
- tests for component
- test for including `this` in mapStateToThis
- return type of connect if mapDispatchtoThis is not given

refs: #2318
shaman-apprentice added a commit that referenced this issue Aug 4, 2021
shaman-apprentice added a commit that referenced this issue Sep 5, 2021
ngrx seems to be the way to go with Angular. Therefore adapt its style, so that future migrating will become more easy

refs: #2318
shaman-apprentice added a commit that referenced this issue Sep 11, 2021
which makes custom handling in threeSceneService deprecated. Having only one global state and flow is more maintanable in general and in concrete it facilitates migrating to Angular.

refs: #2318
shaman-apprentice added a commit that referenced this issue Sep 11, 2021
Missing:
- tests for component
- test for including `this` in mapStateToThis
- return type of connect if mapDispatchtoThis is not given

refs: #2318
shaman-apprentice added a commit that referenced this issue Sep 11, 2021
shaman-apprentice added a commit that referenced this issue Sep 11, 2021
ngrx seems to be the way to go with Angular. Therefore adapt its style, so that future migrating will become more easy

refs: #2318
shaman-apprentice added a commit that referenced this issue Sep 11, 2021
shaman-apprentice added a commit that referenced this issue Sep 13, 2021
as constructor is blocking and should only be used for simple property setting

refs #2318
shaman-apprentice added a commit that referenced this issue Sep 13, 2021
as constructor is blocking and should only be used for simple property setting

refs #2318
shaman-apprentice added a commit that referenced this issue Sep 13, 2021
shaman-apprentice added a commit that referenced this issue Oct 27, 2022
shaman-apprentice added a commit that referenced this issue Oct 27, 2022
shaman-apprentice added a commit that referenced this issue Oct 28, 2022
shaman-apprentice added a commit that referenced this issue Oct 31, 2022
…ose promise in test (#3110)

extract / refactor out LoadInitialFileService
fix Unhandled Promise in tests #2294
ref Wrong calculation for initial file size #3111
ref  Migrate all Angular Components and Services #2318
shaman-apprentice added a commit that referenced this issue Nov 1, 2022
shaman-apprentice added a commit that referenced this issue Nov 1, 2022
@shaman-apprentice
Copy link
Contributor Author

Done. AngularJS is removed. Some todos were moved to Upgrade to Angular 13

LuisGuenther added a commit that referenced this issue Nov 2, 2022
* refactor: PoC SetState action in an single action

ref #2318

* Delete all splitter functions and tests, add tests for root reducer, do some little refactoring
#3092

* Implement restore state with dynamic keys
#3092

* Remove throwing error when key doesn't exist and adjust tests
#2489

* Remove customConfigFileStateConnector
#2489

* Remove assignedMaps and mapNames from custom config model and introduce mapNameByChecksum property, remove treemap size and attribute types from config model
#2489

* Replace customConfigFileStateConnector functions and implement workaround for new property mapNameByChecksum in custom config
#2489

* Adjust selector for getting visible files by selection mode, adjust  dependent functions
#2489

* Adjust all tests to new custom config model and replace CustomConfigFileStateConnector calls with new selector
#2489

* Change visibleFilesSelector with visibleFilesBySelectionMode for getting downloadable custom configs, adjust tests
#2489

* Change visibleFilesSelector with visibleFilesBySelectionMode for getting downloadable custom configs, adjust tests
#2489

* Adjust test for getDownloadableCustomConfigs
#2489

* Implement suggested changes of PR review
#2489

Co-authored-by: shaman-apprentice <Torsten.Knauf@gmx.de>
Co-authored-by: LuisGuenther <93578491+LuisGuenther@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

3 participants