Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Angular 15 #3116

Closed
13 tasks done
shaman-apprentice opened this issue Nov 1, 2022 · 1 comment
Closed
13 tasks done

Upgrade to Angular 15 #3116

shaman-apprentice opened this issue Nov 1, 2022 · 1 comment
Assignees
@shaman-apprentice
Labels
pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.

Comments

@shaman-apprentice
Copy link
Contributor

shaman-apprentice commented Nov 1, 2022 •
edited

Feature request

Angular 12 has end of life on 2022-11-12. Therefore we should migrate to Angular 13+.

Development notes (optional Task Breakdown)

  • split e2e test settings from unit test settings (Seperate unit and e2e test config #2300)
  • upgrade jest to at least v27 as jest-preset-angular seems to need it in combination with angular's build tools
  • replace custom build through Angular's ng tooling. Replace hard coded templates requires (template: require("./metricDeltaSelected.component.html")) through plain paths, and use templateUrl, so that Angular's build can pick them up
  • Follow Angular's migration guide from 12 -> 13 -> 14 -> 15

Clean up tasks / further enhancements

  • Update with Material 15 marked deprecated things Own ticket Migrate to Angular Material v15 MDC components #3225
  • @Inject(...
  • build warnings "CommonJS or AMD dependencies can cause optimization bailouts." - did quick wins
  • unify place for assets (visualizsation/assets and visualizsation/codeCharta/assets)
  • "strictTemplates": false -> true
  • .md-fab // dead css
  • remove deprecated nodeEdgeMetricsMap
  • remove clone from getUndecoratedAccumulatedData is still needed. See refactor: make manipulation more clear #3217
  • replace custom updateProperties.ts again
@shaman-apprentice shaman-apprentice added the pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. label Nov 1, 2022
@shaman-apprentice shaman-apprentice mentioned this issue Nov 2, 2022
Closed
shaman-apprentice added a commit that referenced this issue Jan 2, 2023
@shaman-apprentice
refactor: use correct brackets
bf73518 
which surprisingly doesn't change evaluation due to JS type conversation

ref #3116
@shaman-apprentice shaman-apprentice mentioned this issue Jan 2, 2023
Merged
@shaman-apprentice shaman-apprentice self-assigned this Jan 2, 2023
shaman-apprentice added a commit that referenced this issue Jan 2, 2023
@shaman-apprentice
refactor: remove duplicated calculation for dev mode
05936b6 
ref #3116
@shaman-apprentice shaman-apprentice mentioned this issue Jan 2, 2023
Merged
shaman-apprentice added a commit that referenced this issue Jan 2, 2023
@shaman-apprentice @BridgeAR
refactor: remove duplicated calculation for dev mode (#3185)
db63196 
* refactor: remove duplicated calculation for dev mode

ref #3116

* Update visualization/app/codeCharta/util/envDetector.ts

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
shaman-apprentice added a commit that referenced this issue Jan 2, 2023
@shaman-apprentice
refactor: use string union instead of enum for blacklist type to impr…
9262c4d 
…ove upcoming strict template type checking

ref #3116
@shaman-apprentice shaman-apprentice mentioned this issue Jan 2, 2023
Closed
shaman-apprentice added a commit that referenced this issue Jan 3, 2023
@shaman-apprentice
refactor: upgrade to jest v27
e2d65e6 
ref #3116
@shaman-apprentice shaman-apprentice mentioned this issue Jan 3, 2023
Merged
shaman-apprentice added a commit that referenced this issue Jan 3, 2023
@shaman-apprentice
refactor: adjust to ts-jest/utils' deprecation for mocked
24ad7c2 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 3, 2023
@shaman-apprentice
refactor: remove @types/jest as jest brings its own types
0568cec 
ref #3116
BridgeAR pushed a commit that referenced this issue Jan 3, 2023
@shaman-apprentice @BridgeAR
refactor: use string union instead of enum for blacklist type to impr…
fe1627a 
…ove upcoming strict template type checking

ref #3116
BridgeAR pushed a commit that referenced this issue Jan 3, 2023
@shaman-apprentice @BridgeAR
refactor: upgrade to jest v27
267c8c2 
ref #3116
BridgeAR pushed a commit that referenced this issue Jan 3, 2023
@shaman-apprentice @BridgeAR
refactor: adjust to ts-jest/utils' deprecation for mocked
fdd0a97 
ref #3116
BridgeAR pushed a commit that referenced this issue Jan 3, 2023
@shaman-apprentice @BridgeAR
refactor: remove @types/jest as jest brings its own types
32b0f6e 
ref #3116
BridgeAR pushed a commit that referenced this issue Jan 3, 2023
@shaman-apprentice @BridgeAR
refactor: use correct brackets
a755d57 
which surprisingly doesn't change evaluation due to JS type conversation

ref #3116
shaman-apprentice added a commit that referenced this issue Jan 9, 2023
@shaman-apprentice
refactor: remove a circular dependency fixing a not test critical nul…
83b3e3d 
…l reducer in test

ref #3116
BridgeAR pushed a commit that referenced this issue Jan 9, 2023
@shaman-apprentice @BridgeAR
refactor: remove a circular dependency fixing a not test critical nul…
152affe 
…l reducer in test

ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
refactor: working dev compilation
a24b653 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
refactor: compile to es2020 and fix invalid linting config
2e8165c 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
refactor: adjust to deprecation warning
15b9cee 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
refactor: start dev on port 3000 again
5e8ecf9 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
refactor: use real isDevMode
df0fdc7 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
refactor: run successfully unit tests
6307ba0 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
fix: format changelog as html again
f9dc0e0 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
refactor: remove not needed config
cfc6b02 
ref #3116
shaman-apprentice added a commit that referenced this issue Jan 20, 2023
@shaman-apprentice
refactor: remove not needed html module
22537d9 
ref #3116
@shaman-apprentice shaman-apprentice mentioned this issue Feb 5, 2023
Merged
shaman-apprentice added a commit that referenced this issue Feb 5, 2023
@shaman-apprentice
refactor: replace lodash.isequal
3a70214 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 5, 2023
@shaman-apprentice
refactor: remove @types/lodash as lodash is used no more
2aaf78b 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 5, 2023
@shaman-apprentice
refactor: integrate this scope as requested
7500bc0 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 5, 2023
@shaman-apprentice
refactor: replace fast-deep-equal with dequal/lite
17938d7 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 5, 2023
@shaman-apprentice
refactor: replace tsee through a minimal implementation
23818b8 
as Angular warns about it "CommonJS or AMD dependencies can cause optimization bailouts"

ref #3116
@shaman-apprentice shaman-apprentice mentioned this issue Feb 5, 2023
Merged
shaman-apprentice added a commit that referenced this issue Feb 5, 2023
@shaman-apprentice
refactor: remove redundant parameter
f68886b 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 5, 2023
@shaman-apprentice
refactor: replace md5 through native crypto
1e11a5b 
as Angular warns about it "CommonJS or AMD dependencies can cause optimization bailouts"

ref #3116
@shaman-apprentice shaman-apprentice mentioned this issue Feb 5, 2023
Closed
shaman-apprentice added a commit that referenced this issue Feb 6, 2023
@shaman-apprentice
refactor:
d3f5888 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 6, 2023
@shaman-apprentice
refactor:
094d487 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 6, 2023
@shaman-apprentice @BridgeAR
refactor: remove lodash as Angular warns about it (#3221)
686c48b 
* refactor: replace lodash.debounce

ref #3116

* refactor: replace lodash.isequal

ref #3116

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
shaman-apprentice added a commit that referenced this issue Feb 6, 2023
@shaman-apprentice @BridgeAR
refactor: replace tsee through a minimal implementation (#3222)
594b42f 
* refactor: replace tsee through a minimal implementation

as Angular warns about it "CommonJS or AMD dependencies can cause optimization bailouts"

ref #3116

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
shaman-apprentice added a commit that referenced this issue Feb 6, 2023
@shaman-apprentice
test: clean up subscriptions
100df8c 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 6, 2023
@shaman-apprentice
refactor: remove useless assignment which gets overwritten immediately
013cf3d 
ref #3116
@shaman-apprentice shaman-apprentice mentioned this issue Feb 6, 2023
Merged
This was referenced Feb 7, 2023
Closed
Merged
@shaman-apprentice
Copy link
Contributor Author

everything is done or an own issue was created

shaman-apprentice added a commit that referenced this issue Feb 9, 2023
@shaman-apprentice
test: clean up subscriptions
2cb65af 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 9, 2023
@shaman-apprentice
refactor: remove useless assignment which gets overwritten immediately
4bfaa1e 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 24, 2023
@shaman-apprentice
test: adjust uploadFilesButton.e2e
7d34d21 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 24, 2023
@shaman-apprentice
refactor: remove useless utility
0c00cc4 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 24, 2023
@shaman-apprentice
feat: improve padding
f7098e1 
ref #3116
shaman-apprentice added a commit that referenced this issue Feb 24, 2023
@shaman-apprentice
fix: align text to the middle again
99852d2 
ref #3116
shaman-apprentice pushed a commit that referenced this issue Mar 1, 2023
refactor: remove now unused test helper
bcd90fc 
ref #3116
shaman-apprentice pushed a commit that referenced this issue Mar 1, 2023
test: re-add temporarily disabled test
77b968a 
ref #3116
IhsenBouallegue added a commit that referenced this issue Mar 3, 2023
@IhsenBouallegue @shaman-apprentice
Migrate to MDC-based Angular Material Components (#3226)
22b2fd7 
* refactor: execute the ng migrate command for material ui

#3116

* refactor presentation mode toggle

* fix ribbon bar components

#3225

* fix metric chooser styling

ref #3225

* remove unused code

* fix global configuration dialog styling

* fix wrong css selector

* fix metric chooser panel styling

* fix various styling issues

Ref #3225

* fix tests

ref #3225

* fix various tests

* add cc logo to the UI and change theme colors

* fix e2e tests after mdc migration

* adjust background, checkmark and distribution bar colors

* fix distribution bar test

* use testing harness to fix layout selection test

* fix slider test by using material harness

* fix metric value hovered number display

* remove style property an use scss in area metric panel

* increase setting panel width

* fix slider labels

* switch settings panel to flex

* adjust settings menus and make them uniform

* improve gobal settings styling

* fix link button styling

* remove matSelect old extra styling

* fix remaining todos styling

* fix tests

* test: adjust uploadFilesButton.e2e

ref #3116

* refactor: remove useless utility

ref #3116

* feat: improve padding

ref #3116

* fix: align text to the middle again

ref #3116

* fix: align context menu buttons

* fix: fix ribbon bar suspicious metrics not aligned correctly

* fix: remove not needed wrapper

* test: remove await

* fix: fix changelog dialog title

* docs: add changelog entries

* refactor: remove now unused test helper

ref #3116

* test: re-add temporarily disabled test

ref #3116

---------

Co-authored-by: shaman-apprentice <Torsten.Knauf@gmx.de>
Co-authored-by: TorstenKnauf <Torsten.Knauf-extern@deutschebahn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaman-apprentice shaman-apprentice

Labels
pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shaman-apprentice