Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird metric description #2508

Closed
BridgeAR opened this issue Nov 15, 2021 · 4 comments · Fixed by #2537 or #2547
Closed

Weird metric description #2508

BridgeAR opened this issue Nov 15, 2021 · 4 comments · Fixed by #2537 or #2547
Assignees
@jannikr @Shivan-997
Labels
bug Only issues that describe bugs. javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@BridgeAR
Copy link
Member

Bug

Expected Behavior

GIVEN a map is loaded

WHEN clicking upon the metric type

THEN the types are visible and the description for the search bar is properly readable

Actual Behavior

fl Metric is shown in the search bar.

Screenshots

image

Steps to Reproduce the Problem

  1. Click on the metric type

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.83.0
  • OS: all
  • Browser: all
@BridgeAR BridgeAR added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. javascript Pull requests that update Javascript code. Usually created by Dependabot. priority:high Set by PO labels Nov 15, 2021
@ce-bo
Copy link
Collaborator

ce-bo commented Nov 18, 2021

I cannot reproduce it in the web demo.

@BridgeAR
Copy link
Member Author

I am able to reproduce it on Firefox and Chromium in the web demo on Ubuntu.

Shivan-997 added a commit that referenced this issue Nov 23, 2021
@Shivan-997
WIP: Use icon tag instead of font awesome icon #2508
3ce7244
@jannikr
Copy link
Contributor

jannikr commented Nov 23, 2021

We saw this problem on Kali Linux system too. It is very hard to find a solution that renders icons properly inside the input tag. Therefore we tried to insert the icon inside an i tag. With this solution the icon displays correct on every system. It is a very unpleasant solution, maybe we should research for other options. Keywords: Unicode, FontAwesome, Ubuntu

@Shivan-997 Shivan-997 mentioned this issue Nov 29, 2021
Merged
Shivan-997 added a commit that referenced this issue Nov 29, 2021
@Shivan-997
WIP: Use icon tag instead of font awesome icon #2508
5b14025
Shivan-997 added a commit that referenced this issue Nov 29, 2021
@Shivan-997
WIP: move search bar 1px to right #2508
e29ed7d
Shivan-997 added a commit that referenced this issue Dec 6, 2021
@Shivan-997
resolve change requests #2508
a77e636
Shivan-997 added a commit that referenced this issue Dec 6, 2021
@Shivan-997
Fix focus searchbar #2508
89489c5
Shivan-997 added a commit that referenced this issue Dec 7, 2021
@Shivan-997
Fix metric chooser test #2508
466d9a6
Shivan-997 added a commit that referenced this issue Dec 7, 2021
@Shivan-997
Add Entry to Changelog #2508
1d44cd1
Shivan-997 added a commit that referenced this issue Dec 7, 2021
@Shivan-997
remove unnecessary div tag, fix edge chooser test #2508
c7ce590
Shivan-997 added a commit that referenced this issue Dec 7, 2021
@Shivan-997
add search-bar class name to area metric chooser #2508
6281a7b
ce-bo pushed a commit that referenced this issue Dec 7, 2021
@Shivan-997
Use icon tag instead of font awesome icon (#2537)
0d8509f 
* WIP: Use icon tag instead of font awesome icon #2508

* WIP: Use icon tag instead of font awesome icon #2508

* WIP: move search bar 1px to right #2508

* resolve change requests #2508

* Fix focus searchbar #2508

* Fix metric chooser test #2508

* Add Entry to Changelog #2508

* remove unnecessary div tag, fix edge chooser test #2508

* add search-bar class name to area metric chooser #2508
@BridgeAR
Copy link
Member Author

BridgeAR commented Dec 7, 2021

I am going to reopen it even though it's more like a new issue:

Ideally, the placeholders contain the metric name (Color Metric, Edge Metric, Height Metric, Size Metric).

@BridgeAR BridgeAR reopened this Dec 7, 2021
@Shivan-997 Shivan-997 mentioned this issue Dec 7, 2021
Merged
Hall-Ma added a commit that referenced this issue Dec 8, 2021
@Hall-Ma
Rename title of size metric options and update CHANGELOG.md
a42cd16 
#2508
ce-bo added a commit that referenced this issue Dec 8, 2021
@Shivan-997 @Hall-Ma @ce-bo
change text for placeholder of metric chooser (#2547)
6402fa7 
* change text for placeholder of metric chooser

* Rename title of size metric options and update CHANGELOG.md
#2508

* Update CHANGELOG.md

Co-authored-by: Maria Hallmann <maria.hallmann@student.htw-berlin.de>
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jannikr jannikr

@Shivan-997 Shivan-997

Labels
bug Only issues that describe bugs. javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
4 participants
@BridgeAR @ce-bo @jannikr @Shivan-997