Use icon tag instead of font awesome icon #2537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now, the search bar is a bit weird (Area, Height metric): Color Metric looks good. |
Shivan-997
changed the title
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!
|
|
There is another small regression: The Icon is cut off if the Browser Window is resized smaller. |
ce-bo
reviewed
Nov 30, 2021
visualization/app/codeCharta/ui/metricChooser/metricChooser.component.scss
Show resolved
Hide resolved
Christian-Eberhard
suggested changes
Dec 6, 2021
visualization/app/codeCharta/ui/edgeChooser/edgeChooser.component.html
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/metricChooser/metricChooser.area.component.html
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/metricChooser/metricChooser.color.component.html
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/metricChooser/metricChooser.component.scss
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/metricChooser/metricChooser.component.scss
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/metricChooser/metricChooser.distribution.component.html
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/metricChooser/metricChooser.height.component.html
Outdated
Show resolved
Hide resolved
Christian-Eberhard
approved these changes
Dec 6, 2021
ce-bo
reviewed
Dec 7, 2021
visualization/app/codeCharta/ui/metricChooser/metricChooser.area.component.html
Outdated
Show resolved
Hide resolved
|
Please adjust the description of this PR to close the referenced issue. |
ce-bo
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use icon tag instead of font awesome icon
closes: #2508
Description
The font awesome icon should be replaced with an html Icon tag for mertic chooser components search bar.