Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undefined metric description #2575

Closed
BridgeAR opened this issue Dec 20, 2021 · 0 comments · Fixed by #2883
Closed

undefined metric description #2575

BridgeAR opened this issue Dec 20, 2021 · 0 comments · Fixed by #2883
Assignees
@charlotteKehm @MW-Friedrich
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO
Milestone
automation-basics-2

Comments

@BridgeAR
Copy link
Member

Bug

Expected Behavior

GIVEN a map with statements

WHEN checking the suspicous metrics

THEN there's a description what that stands for or nothing

Actual Behavior

It's an undefined description

Screenshots

image
@BridgeAR BridgeAR added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. javascript Pull requests that update Javascript code. Usually created by Dependabot. priority:medium Set by PO difficulty:low Solving this is likely not that difficult labels Dec 20, 2021
@ce-bo ce-bo added this to the automation-basics-2 milestone Jun 30, 2022
MW-Friedrich added a commit that referenced this issue Jul 6, 2022
@MW-Friedrich
add new metric description for 'statements'
1c99951 
#2575
@MW-Friedrich MW-Friedrich mentioned this issue Jul 6, 2022
Merged
@MW-Friedrich MW-Friedrich linked a pull request Jul 6, 2022 that will close this issue
fix undefined metric description #2883
Merged
MW-Friedrich added a commit that referenced this issue Jul 6, 2022
@MW-Friedrich
add logic to omit a metric description if it does not exist
e99c832 
#2575
MW-Friedrich added a commit that referenced this issue Jul 6, 2022
@MW-Friedrich
update CHANGELOG.md
401d437 
#2575
MW-Friedrich added a commit that referenced this issue Jul 6, 2022
@MW-Friedrich
refactor getNameAndDescriptionOfMetric
2282f54 
#2575
charlotteKehm added a commit that referenced this issue Jul 6, 2022
@charlotteKehm
test: getNameAndDescriptionOfMetric #2575
dd26444
MW-Friedrich added a commit that referenced this issue Jul 6, 2022
@MW-Friedrich @charlotteKehm
fix undefined metric description (#2883)
fc0061f 
* add new metric description for 'statements'
#2575

* add logic to omit a metric description if it does not exist
#2575

* update CHANGELOG.md
#2575

* refactor getNameAndDescriptionOfMetric
#2575

* add a test to make sure that metrics without a description do not cause a 'undefined' description#2575

Co-authored-by: Charlotte Kehm <charlotte.kehm@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlotteKehm charlotteKehm

@MW-Friedrich MW-Friedrich

Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:medium Set by PO
Projects
None yet
Milestone
automation-basics-2
Development

Successfully merging a pull request may close this issue.

fix undefined metric description MaibornWolff/codecharta
4 participants
@BridgeAR @ce-bo @charlotteKehm @MW-Friedrich