Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined metric description #2883

Merged
merged 5 commits into from Jul 6, 2022

Conversation

MW-Friedrich
Copy link
Contributor

@MW-Friedrich MW-Friedrich commented Jul 6, 2022

Issue: #2575

Description

Adds a description for the statement metric.
Fixes an error where if an unsuspicious metric had no description, "undefined" was displayed. Now there is no description in that case.

Screenshots or gifs

image

@MW-Friedrich MW-Friedrich added this to the automation-basics-2 milestone Jul 6, 2022
@MW-Friedrich MW-Friedrich linked an issue Jul 6, 2022 that may be closed by this pull request
@MW-Friedrich MW-Friedrich changed the title add new metric description for 'statements' fix undefined metric description Jul 6, 2022
@MW-Friedrich MW-Friedrich marked this pull request as ready for review July 6, 2022 14:02
@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 6, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@MW-Friedrich MW-Friedrich merged commit fc0061f into main Jul 6, 2022
@MW-Friedrich MW-Friedrich deleted the fix/2575/undefined-metric-description branch July 6, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined metric description
4 participants