Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Project Name if not empty or blank #2671

Closed
Richargh opened this issue Feb 18, 2022 · 0 comments · Fixed by #2767
Closed

Display Project Name if not empty or blank #2671

Richargh opened this issue Feb 18, 2022 · 0 comments · Fixed by #2767
Assignees
@cschild
Labels
difficulty:low Solving this is likely not that difficult javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO UX / UI Everything related to design and user experience

Comments

@Richargh
Copy link

Feature request

Description

When I load cc.json files via url (https://maibornwolff.github.io/codecharta/visualization/app/index.html?file=https:%2F%2Fraw.githubusercontent.com%2FMaibornWolff%2Fcodecharta%2Fmain%2Fgh-pages%2Fassets%2Fccjson%2Fshowcase%2Fjunit4%2Fjunit4_2016-10-28.cc.json), then the file name is no longer properly readable:

grafik

grafik

Can CodeCharta instead display the "projectName" if it's not empty or blank?

Acceptance criteria

  • CodeCharta displays the "projectName" if it's not empty or blank?
  • if "projectName" is empty or blank and the URL is very long, then CodeCharta shows the last characters of the URL, not the first.
@BridgeAR BridgeAR added pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. javascript Pull requests that update Javascript code. Usually created by Dependabot. priority:high Set by PO difficulty:low Solving this is likely not that difficult UX / UI Everything related to design and user experience labels Mar 11, 2022
@cschild cschild self-assigned this Mar 31, 2022
cschild added a commit that referenced this issue Mar 31, 2022
@cschild
Display project name if not empty or blank #2671
07fd0fb
cschild added a commit that referenced this issue Mar 31, 2022
@cschild
Display last part of URL if project name empty or blank #2671
f893790
@cschild cschild mentioned this issue Mar 31, 2022
Merged
cschild added a commit that referenced this issue Mar 31, 2022
@cschild
Refactor getFileName #2671
7e46c0c
Hall-Ma added a commit that referenced this issue Mar 31, 2022
@Hall-Ma
Adjust expected file names in e2e tests when getting url files
d8c4b5e 
#2671
Hall-Ma added a commit that referenced this issue Mar 31, 2022
@Hall-Ma
Add a test to ensure that a given project name is set to file name wh…
86a3157 
…en a file is given via URL

#2671
Hall-Ma added a commit that referenced this issue Mar 31, 2022
@Hall-Ma
Adjust test
6fa56da 
#2671
Hall-Ma added a commit that referenced this issue Mar 31, 2022
@Hall-Ma
Add changelog entry
71d9a1d 
#2671
Hall-Ma added a commit that referenced this issue Mar 31, 2022
@cschild @Hall-Ma @ce-bo
Feature/2671/display project name if not empty or blank (#2767)
ec98343 
* Display project name if not empty or blank #2671

* Display last part of URL if project name empty or blank #2671

* Refactor getFileName #2671

* Adjust expected file names in e2e tests when getting url files
#2671

* Add a test to ensure that a given project name is set to file name when a file is given via URL
#2671

* Adjust test
#2671

* Add changelog entry
#2671

Co-authored-by: Hall-Ma <maria.hallmann@student.htw-berlin.de>
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cschild cschild

Labels
difficulty:low Solving this is likely not that difficult javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO UX / UI Everything related to design and user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/2671/display project name if not empty or blank MaibornWolff/codecharta
3 participants
@BridgeAR @Richargh @cschild