Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2671/display project name if not empty or blank #2767

Merged
merged 8 commits into from Mar 31, 2022
Merged

Feature/2671/display project name if not empty or blank #2767

merged 8 commits into from Mar 31, 2022

Conversation

cschild
Copy link
Contributor

@cschild cschild commented Mar 31, 2022

Display project name if not empty or blank

Close: #2671

Description

  • Displays the file projectName if it's not empty or blank
  • Otherwise, displays the last part of the URL

ce-bo
ce-bo approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog entry.

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit ec98343 into main Mar 31, 2022
@Hall-Ma Hall-Ma deleted the feature/2671/display-project-name-if-not-empty-or-blank branch March 31, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display Project Name if not empty or blank
4 participants
@cschild @BridgeAR @ce-bo @Hall-Ma