-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand directory summary for delta mode #2708
Comments
Question about the UI suggestion: (Or in other words, the blue number equals the square of changed files? |
@knoffi green represents all newly added files. Red represents removed files and blue represents existing changed files that were not removed. |
@BridgeAR Thanks for the fast reply. So the black text "5 files" stands for the number of changed files, and thus |
No, there is no real correlation between the entries. Black represents the total number of files. Blue is the number of changed files (a subset of black). |
Finally, I fully understand my confusion: In the description, it is stated: "... when a delta value is not equal to 0 then there is a changed file." This refers to the property in I thought that the description was refering to the displayed values "∆1 | ∆-1 " , because "∆" is a big delta letter. Thus, I was assuming there was some correlation between them. Additionally, when I read "squarified" I was assuming someone was calculating the square number of something. Sorry for the delay. |
[Less symmetry in expected result when counting added+deleted files]
[check english grammar for plural/singular edge cases]
[edge case of folder with 0 files is now displayed with correct grammar]
[Text shows correctly that a file changed if and only a metric changed]
[For-loop instead of lambda-functions for perfomance in delta generator]
[Using set instead of array to improve performance]
[0 should equal undefined when comparing attributes]
[Snapshots use https and mocks have correct propery order]
[Reduce duplicated lines marked by sonarqube]
[Extract fileMeta proeprty to reduce code duplication]
[Reduce code duplication for sonar qube]
* Improve delta generator spec #2708 [Less symmetry in expected result when counting added+deleted files] * Improve nodePath spec #2708 [check english grammar for plural/singular edge cases] * Fix grammar in file count display #2708 [edge case of folder with 0 files is now displayed with correct grammar] * Add mocked display of changed files #2708 * Fix information display about changed files #2708 [Text shows correctly that a file changed if and only a metric changed] * Add file comparing in delta generator #2708 * Add metricsChanged by delta generator #2708 * Add display of changed files in html from store #2708 * Fix fileCount selector spec #2708 * Add collecting of metric changes from children #2708 * Refactor FileCount property #2708 [ .metricsChanged to .changed ] * Fix snapshots for delta generator spec #2708 * Fix logic of delta generator #2708 [For-loop instead of lambda-functions for perfomance in delta generator] * Document changelog #2708 * Refactor deltaGenerator internally #2708 [Using set instead of array to improve performance] * Fix file-changed-logic in deltaGenerator #2708 [0 should equal undefined when comparing attributes] * Change google link to https #2708 * Adjust test mocks and snapshots #2708 [Snapshots use https and mocks have correct propery order] * Refactor test mock objects #2708 [Reduce duplicated lines marked by sonarqube] * Refactor mock objects for unit tests #2708 [Extract fileMeta proeprty to reduce code duplication] * Refactor test mock objects #2707 [Extracted default file and default fileMap] * Refactor mock files in deltaGenerator spec #2708 [Reduce code duplication for sonar qube] * Try out comment to disable sonar in line #2708 * fix SonarQube not excluding dataMocks.ts #1532 Co-authored-by: MW-Friedrich <108457762+MW-Friedrich@users.noreply.github.com> Co-authored-by: Jan N. Rückert <31436472+jannikr@users.noreply.github.com>
Fix missing wildcard pattern in sonar.properties #2708
* Fix CHANGELOG.md entry for delta display Fix missing wildcard pattern in sonar.properties #2708 * Update CHANGELOG.md Remove weird line break
Feature request
Description
As a user, I want to see the number of changed files in a selected folder next to added and removed files in delta mode so that I get a quick overview of the dimension of the changes of both maps.
Acceptance criteria
Development notes (optional Task Breakdown)
fileCount
property insquarifiedNode
The text was updated successfully, but these errors were encountered: