Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/2708/show changed files in delta mode #2890

Merged
merged 32 commits into from Jul 27, 2022
Merged

Feature/2708/show changed files in delta mode #2890

merged 32 commits into from Jul 27, 2022

Conversation

knoffi
Copy link
Contributor

@knoffi knoffi commented Jul 15, 2022 •
edited by MW-Friedrich

Display number of files with metric changes in delta mode

Issue: #2708

Description

Descriptive pull request text, answering:

  • What problem/issue are you fixing?
  • What does this PR implement and how?

Screenshots or gifs

knoffi and others added 8 commits July 15, 2022 11:24
@knoffi
Improve delta generator spec #2708
538ba0f 
[Less symmetry in expected result when counting added+deleted files]
@knoffi
Improve nodePath spec #2708
c7feb84 
[check english grammar for plural/singular edge cases]
@knoffi
Fix grammar in file count display #2708
0b37caa 
[edge case of folder with 0 files is now displayed with correct grammar]
@knoffi
Add mocked display of changed files #2708
1a154cc
@knoffi
Fix information display about changed files #2708
9fd665c 
[Text shows correctly that a file changed if and only a metric changed]
@knoffi
Add file comparing in delta generator #2708
97861ab
@knoffi
Add metricsChanged by delta generator #2708
5acb25e
@MW-Friedrich
Merge branch 'main' into feature/2708/show-changed-files-in-delta-mode
f871d85
BridgeAR
BridgeAR reviewed Jul 24, 2022
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the draft mode still intentional? :-)
It already looks very good to me! I just left a few minor comments and the changelog entry should be added as well.

visualization/app/codeCharta/util/deltaGenerator.ts Outdated Show resolved Hide resolved
visualization/app/codeCharta/util/deltaGenerator.ts Outdated Show resolved Hide resolved
visualization/app/codeCharta/util/deltaGenerator.ts Outdated Show resolved Hide resolved
visualization/app/codeCharta/util/deltaGenerator.ts Outdated Show resolved Hide resolved
@knoffi knoffi marked this pull request as ready for review July 25, 2022 12:49
@knoffi
Refactor deltaGenerator internally #2708
71bc9c6 
[Using set instead of array to improve performance]
@knoffi
Fix file-changed-logic in deltaGenerator #2708
5a13982 
[0 should equal undefined when comparing attributes]
@knoffi
Copy link
Contributor Author

knoffi commented Jul 26, 2022 •
edited

Feel free to push the button and merge on final approve. : )

@ce-bo
Copy link
Collaborator

ce-bo commented Jul 26, 2022

Would you please have a look on dataMock.ts.
Maybe we can reduce the duplicated code, so that Sonar Quality Gate is not failing.

@MW-Friedrich MW-Friedrich linked an issue Jul 27, 2022 that may be closed by this pull request
Expand directory summary for delta mode #2708
Closed
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

phanlezz
phanlezz reviewed Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@phanlezz phanlezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@knoffi knoffi merged commit caff7c6 into main Jul 27, 2022
@knoffi knoffi deleted the feature/2708/show-changed-files-in-delta-mode branch July 27, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@phanlezz phanlezz phanlezz approved these changes

Assignees

@knoffi knoffi

@phanlezz phanlezz

@MW-Friedrich MW-Friedrich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand directory summary for delta mode
6 participants
@knoffi @ce-bo @BridgeAR @phanlezz @MW-Friedrich @jannikr