Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suspicious Metrics Overlay is empty for maps without known metrics #2962

Closed
ce-bo opened this issue Aug 8, 2022 · 2 comments
Closed

Suspicious Metrics Overlay is empty for maps without known metrics #2962

ce-bo opened this issue Aug 8, 2022 · 2 comments
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Milestone
automation-basics-3

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Aug 8, 2022

Bug

Expected Behavior

WHEN
loading a map with a set of metrics that are unknown/not listed in artificialIntelligence.metricThresholds.ts

THEN
the Suspicious Metric Menu should show the message "The given metrics are not covered by this feature, so no finding could be made".

Actual Behavior

A small and empty Menu is loaded.

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.101.0
  • OS: all
  • Browser: all
@ce-bo ce-bo added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO difficulty:low Solving this is likely not that difficult labels Aug 8, 2022
@ce-bo ce-bo added this to the automation-basics-3 milestone Aug 8, 2022
jannikr added a commit that referenced this issue Aug 25, 2022
@jannikr
Add untracked metrics to suspiciousMetricsHelper.ts #2962
81878ae
@jannikr jannikr mentioned this issue Aug 25, 2022
Merged
4 tasks
jannikr added a commit that referenced this issue Aug 30, 2022
@jannikr
Add hover description to new section and fix alignment #2962
af6cd78
jannikr added a commit that referenced this issue Aug 30, 2022
@jannikr
Minor improvements #2962
88e9a4f
jannikr added a commit that referenced this issue Aug 30, 2022
@jannikr
Adapt tests to new struct #2962
36b000f
jannikr added a commit that referenced this issue Aug 30, 2022
@jannikr
Add test #2962
0192968
jannikr added a commit that referenced this issue Aug 30, 2022
@jannikr
Update CHANGELOG.md #2962
b07efd6
jannikr added a commit that referenced this issue Aug 31, 2022
@jannikr
Refactor untrackedMetrics in suspiciousMetricsHelper.ts #2962
b0caad2
jannikr added a commit that referenced this issue Aug 31, 2022
@jannikr
Add untracked metrics to suspiciousMetricsHelper.ts #2962 (#2996)
4f1d8fd 
* Add untracked metrics to suspiciousMetricsHelper.ts #2962

* Add hover description to new section and fix alignment #2962

* Minor improvements #2962

* Adapt tests to new struct #2962

* Add test #2962

* Update CHANGELOG.md #2962

* Update CHANGELOG.md

* Refactor untrackedMetrics in suspiciousMetricsHelper.ts #2962
@MW-Friedrich
Copy link
Contributor

Has this been closed by #2996 ? @jannikr

@ce-bo
Copy link
Collaborator Author

ce-bo commented Sep 6, 2022

Closed by #2996.

@ce-bo ce-bo closed this as completed Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
automation-basics-3
Development

No branches or pull requests
2 participants
@ce-bo @MW-Friedrich