Add untracked metrics to suspiciousMetricsHelper.ts #2962

[jannikr]

Suspicious Metrics Overlay is empty for maps without known metrics

Issue: #2962

Additionally I suggest adding untracked metrics to the list even though the overlay appears right. This could be useful to inform the user about metrics that could not be tested. For example every metric might be unsuspicious but what about the other metrics that have not been tested. This feature allows the user to be warned about "untracked" metrics.

Next steps:

• Fix material tooltip (hovering does not work and alignment is not right yet)
• Improve code readability
• Write tests
• Add CHANGELOG.md entry

[Hall-Ma]

I have another idea to this issue. All you need is this:

	for (const key in metricValuesByLanguages[mainProgrammingLanguage]) {
		const keys = Object.keys(languageSpecificMetricThresholds)
		if (!keys.includes(key) && !metricAssessmentResults.untrackedMetrics.includes(key)) {
			metricAssessmentResults.untrackedMetrics.push(key)
		}
	}

So we wouldn't need that array in array thing, that is really confusing me :D
But your approch is also good!

[jannikr]

I have another idea to this issue. All you need is this:

	for (const key in metricValuesByLanguages[mainProgrammingLanguage]) {
		const keys = Object.keys(languageSpecificMetricThresholds)
		if (!keys.includes(key) && !metricAssessmentResults.untrackedMetrics.includes(key)) {
			metricAssessmentResults.untrackedMetrics.push(key)
		}
	}

So we wouldn't need that array in array thing, that is really confusing me :D But your approch is also good!

@Hall-Ma I agree with you and find your solution more feasible!

[sonarcloud]

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[sonarcloud]

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication