Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin renders some buildings invisible #3044

Open
RomanenkoVladimir opened this issue Sep 20, 2022 · 2 comments · Fixed by #3077
Open

Margin renders some buildings invisible #3044

RomanenkoVladimir opened this issue Sep 20, 2022 · 2 comments · Fixed by #3077
Labels
blocked The issue or feature is blocked on another issue or PR that has to be resolved first bug Only issues that describe bugs.

Comments

@RomanenkoVladimir
Copy link
Member

Bug

Due to D3's algorithm using margins between buildings removes small buildings entirely as they are not calculated, furthermore sizes are not correct, e.g. a buildings of size 400 is not 4 times larger then a building of size 100.

Expected Behavior

All buildings are calculated and placed on the map

A CodeCharta map with small buildings
WHEN
the map is visualized
THEN
all buildings are displayed with correct sizes

Actual Behavior

sizes are incorrect and some are not displayed at all

Specifications

Notes

Part 1 of the refactoring for PR for issue #1609

@phanlezz
Copy link
Collaborator

phanlezz commented Nov 4, 2022

Sorry wrong PR

@RomanenkoVladimir
Copy link
Member Author

I think the issue might be a result of using Math.cell() to often, please take a look and remove all intermediate usage by only applying it in the end instead :)

@ce-bo ce-bo added the blocked The issue or feature is blocked on another issue or PR that has to be resolved first label Dec 9, 2022
@ce-bo ce-bo removed this from the automation-basics-4 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked The issue or feature is blocked on another issue or PR that has to be resolved first bug Only issues that describe bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants