Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse pr 3077 commit b3b112e7 #3161

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Reverse pr 3077 commit b3b112e7 #3161

merged 3 commits into from
Dec 1, 2022

Conversation

phanlezz
Copy link
Collaborator

@phanlezz phanlezz commented Dec 1, 2022

This reverts the changes from pr #3077 (merge commit b3b112e7)

Issue #3159

Description

This will revert PR #3077, that tried to fix Issue #3044. The PR introduced a bug where same size buildings would not be rendered proportional to each other.

Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phanlezz phanlezz changed the title Reverse pr 3077 commit b3b12e7 Reverse pr 3077 commit b3b112e7 Dec 1, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

96.4% 96.4% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ce-bo ce-bo merged commit 8b99177 into main Dec 1, 2022
@ce-bo ce-bo deleted the fix/3159/revert-pr-3077 branch December 1, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants