Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Risk-Profile throws erros when programming language is undefined #3143

Closed
MW-Friedrich opened this issue Nov 23, 2022 · 3 comments
Closed

Risk-Profile throws erros when programming language is undefined #3143

MW-Friedrich opened this issue Nov 23, 2022 · 3 comments
Assignees
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@MW-Friedrich
Copy link
Contributor

MW-Friedrich commented Nov 23, 2022

Bug

This was discovered in #3077 but had a different origin.

Expected Behavior

GIVEN a heavily anonimised cc.json file

WHEN the file does not contain a programming language

THEN the risk profile and suspicious metrics should show that no calculations could be made.

Actual Behavior

GIVEN a heavily anonimised cc.json file

WHEN the file does not contain a programming language

THEN the programming language is left at undefined and the risk calculation fails with an error.

Steps to Reproduce the Problem

  1. Upload a .cc.json file where no programming language is specified or can be inferred

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.111.0
  • OS: Windows
  • Browser: Firefox
@MW-Friedrich MW-Friedrich added the bug Only issues that describe bugs. label Nov 23, 2022
@ce-bo ce-bo added pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO difficulty:low Solving this is likely not that difficult good first issue labels Nov 23, 2022
@ce-bo
Copy link
Collaborator

ce-bo commented Nov 23, 2022

I would add something:
If no programming language could be inferred, all files should be assessed based on default threshold values.

@MW-Friedrich is it possbile to include this requirement in the scope of this issue?

@MW-Friedrich
Copy link
Contributor Author

I would add something: If no programming language could be inferred, all files should be assessed based on default threshold values.

@MW-Friedrich is it possbile to include this requirement in the scope of this issue?

I would say something like this would be best to handle as a new feature request. At the moment both the Risk-Profile and Suspicious Metrics feature just "turn off" when no programming language is given, so adding this behaviour would be a bigger undertaking. Should I maybe open a new feature request for this?

@ce-bo
Copy link
Collaborator

ce-bo commented Nov 23, 2022

I will keep track of it and I will open the issue, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult good first issue pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Development

No branches or pull requests

3 participants