Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the window is too small horizontally the controls get hidden #582

Closed
Richargh opened this issue Jun 19, 2019 · 7 comments · Fixed by #636
Closed

If the window is too small horizontally the controls get hidden #582

Richargh opened this issue Jun 19, 2019 · 7 comments · Fixed by #636
Assignees
@alexhunziker
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.

Comments

@Richargh
Copy link

Richargh commented Jun 19, 2019 •
edited

Bug

Controls in our file and metric bar disappear when the window is too small horizontally. The user now has no way to know that content is missing.

Expected Behavior

The user knows that content is missing or there is no way that content is missing. Please do not show a burger menu.

Actual Behavior

Content is missing.
@Richargh Richargh added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Jun 19, 2019
@Richargh Richargh mentioned this issue Jun 19, 2019
Closed
@Richargh
Copy link
Author

By accident I stumbled over an idea sausage links :)

@alschmut
Copy link
Contributor

As a first step. The sections don't get hidden, when there's no space

image

alschmut added a commit that referenced this issue Jun 28, 2019
@alschmut
Show also partly visible section in ribbonBar when window is too small …
2159c4f 
…#582
alschmut added a commit that referenced this issue Jun 28, 2019
@alschmut
Show also partly visible section in ribbonBar when window is too small …
443c5c2 
…#582
@Richargh
Copy link
Author

Nice. I am tempted to leave it at that and apply the same idea to the file bar. What do you think?

@alexhunziker
Copy link
Contributor

As a side effect of #526 the ribbon bar now looks like this, if there is not enough space:
grafik
So I guess I fixed this one by accident too :)

@alschmut
Copy link
Contributor

@alexhunziker I think i removed 1 or 2 unused CSS lines on the ribbonBar. Maybe we can remove those on #526 as well

@alexhunziker
Copy link
Contributor

just checked that; you probably mean the vertical-align:top. I tried to remove it, but it seams that with the searchPanel we actually need it.

@alexhunziker
Copy link
Contributor

alexhunziker commented Jul 15, 2019 •
edited

we should probably also update the file panel to show the same behaviour as the ribbon bar...

alexhunziker added a commit that referenced this issue Jul 15, 2019
@alexhunziker
filePanel now shows cut-off items #582
10922b2
alexhunziker added a commit that referenced this issue Jul 15, 2019
@alexhunziker
update Changelog #582
4452639
@alexhunziker alexhunziker mentioned this issue Jul 15, 2019
Merged
11 tasks
@alexhunziker alexhunziker self-assigned this Jul 15, 2019
alexhunziker added a commit that referenced this issue Jul 18, 2019
@alexhunziker
settings now floats over toolBar components if window too small #582
9bbb220
alexhunziker added a commit that referenced this issue Jul 18, 2019
@alexhunziker
responsive filePanel #582
c18ab7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexhunziker alexhunziker

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/582/Show cut-off controls MaibornWolff/codecharta
3 participants
@alexhunziker @alschmut @Richargh