Refactor/2318/migrate node serach service #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As store should only contain plain atomic information. Tests must still be migrated refs #2318
shaman-apprentice
force-pushed
the
refactor/2318/migrate-node-serach-service
branch
from
4c4dedc
to
d67620e
Compare
added 4 commits
November 9, 2021 18:50
…-node-serach-service
…-node-serach-service
ce-bo
reviewed
Nov 11, 2021
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
refs: #2318
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
IhsenBouallegue
approved these changes
Nov 12, 2021
IhsenBouallegue
deleted the
refactor/2318/migrate-node-serach-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store should only contain unique atomic data. Searched nodes path can be derived from searchPattern. Therefore the migration of
nodeSearch.servicewas to extract the logic into a selector and remove it 😎