Refactor/2318/prepare migration of metric data services #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BridgeAR
approved these changes
Nov 18, 2021
visualization/app/codeCharta/state/store/metricData/nodeMetricData/nodeMetricData.service.ts
Outdated
Show resolved
Hide resolved
visualization/app/codeCharta/ui/codeMap/codeMap.preRender.service.spec.ts
Outdated
Show resolved
Hide resolved
…ice.spec.ts Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
- which keeps previous behaviour - is more performant refs: #2318
|
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!
|
|
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
shaman-apprentice
deleted the
refactor/2318/prepare-migration-of-metric-data-services
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the calculation of metric data into selectors, so that we can easily access them from Angular components to come during migration.
The only "real" change, is that on
onAttributeTypesChangednodeMetricDataandedgeMetricDataaren't recalculated anymore, as they are independent ofattributeType.