Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/extract and migrate slider 2 #2787

Merged
merged 10 commits into from Apr 26, 2022
Merged

Refactor/2318/extract and migrate slider 2 #2787

merged 10 commits into from Apr 26, 2022

Conversation

shaman-apprentice
Copy link
Contributor

This PR does:

  • extract and migrate a common slider component for panel settings
  • fixes issue 2786

close #2786
ref #2318

@shaman-apprentice shaman-apprentice marked this pull request as ready for review April 24, 2022 20:11
IhsenBouallegue
IhsenBouallegue approved these changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

CHANGELOG.md Outdated Show resolved Hide resolved
@shaman-apprentice @IhsenBouallegue
Update CHANGELOG.md
7663e97 
Co-authored-by: Ihsen Bouallegue <48621967+IhsenBouallegue@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.0% 98.0% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit 6190747 into main Apr 26, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/extract-and-migrate-slider-2 branch April 26, 2022 15:54
@shaman-apprentice shaman-apprentice mentioned this pull request May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IhsenBouallegue IhsenBouallegue IhsenBouallegue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

area settings panel input field for margin doesn't update slider correctly
2 participants
@shaman-apprentice @IhsenBouallegue