Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/migrate range slider component #2797

Merged
merged 56 commits into from May 17, 2022
Merged

Refactor/2318/migrate range slider component #2797

merged 56 commits into from May 17, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented May 12, 2022 •
edited

close #2798
close #2801
close #2802
close #2803
ref #2318

TODO

  • check scenarios saved min and max color range values as they are now derived from node metric values

shaman-apprentice and others added 30 commits May 3, 2022 21:31
@shaman-apprentice
refactor: add skelton for range-slider
0bc37fa 
ref #2318
refactor: decide to hard code width
55e3b47 
as it is only used with 160px

ref #2318
refactor: add skelton for 3 color section
a8b12d9 
ref #2318
refactor: calculate real width of sections
c7c7498 
ref #2318
refactor: add skelton for dragging left thumb
bbc8f56 
ref #2318
refactor: add thumbPosition2Value
fb54ca3 
ref #2318
refactor: add PoC for dynamically controlled value
08131af 
ref #2318
refactor: finalize poc for controlled value
df7dc7c 
ref #2318
refactor: add right thumb
41a2a50 
ref #2318
refactor: prevent thumbs from overtake each other
9750650 
ref #2318
refactor: implement input fields
1fd095f 
ref #2318
refactor: style thumb and add value
c1376ce 
ref #2318
@shaman-apprentice
refactor: migrate to manual
ec7f3d7 
as cdkDrag API is not exactly what we need

ref #2318
@shaman-apprentice
refactor: implement working version
7f3ef67 
ref #2318
@shaman-apprentice
refactor: clean up
d00808c 
ref #2318
@shaman-apprentice
refactor: add skelton for labels
2ef9cb6 
ref #2318
@shaman-apprentice
refactor: aling labels and hide min max labels in case of overlapping
783b7cc 
ref #2318
@shaman-apprentice
refactor: init correctly
43b62ee 
ref #2318
@shaman-apprentice
refactor: finish features for labels
4f6fb47 
including from-to label

ref #2318
@shaman-apprentice
refactor: add skelton for connected range slider
53edab6 
ref #2318
@shaman-apprentice
refactor: wip connecting
9c22e76 
ref #2318
@shaman-apprentice
refactor: connect color range
a77bdba 
ref #2318
@shaman-apprentice
refactor: add debounce to color range update
4b2d16c 
ref #2318
@shaman-apprentice
refactor: connect color
8dec139 
ref #2318
@shaman-apprentice
refactor: fix flaky alignment of labels
26136d0 
ref #2318
@shaman-apprentice
refactor: disable when in delta state
69686f0 
ref #2318
@shaman-apprentice
refactor: remove decimals from displayed values
b59d3ef 
ref #2318
@shaman-apprentice
Merge remote-tracking branch 'origin/main' into refactor/2318/migrate…
531990c 
…-range-slider-component
@shaman-apprentice
refactor: add tracking
3bc94a3 
ref #2318
@shaman-apprentice
refactor: update labels on slide
d1e1cbe 
ref #2318
@shaman-apprentice
Merge remote-tracking branch 'origin/main' into refactor/2318/migrate…
59bf8f6 
…-range-slider-component
@shaman-apprentice
feat: hide metric color range slider in delta state
ebcdd6c 
instead of disabling it

ref #2318
@shaman-apprentice
refactor: add tests for calculations
2e0e91f 
ref #2318
@shaman-apprentice
refactor: prevent input changes to be out of range
2f01253 
ref #2318
@shaman-apprentice
refactor: add some tests
8c674e8 
ref #2318
@shaman-apprentice
refactor: add some further tests
e546b34 
ref #2318
@shaman-apprentice
docs: add a fix to changelog
8a002a1 
ref #2318
@shaman-apprentice
test: give reasonable default color range and adjust tests
1de3d6e 
ref #2318
@shaman-apprentice
refactor: remove now unused property
cd46b12 
ref #2318
@shaman-apprentice
refactor: remove another now unused property
cd615f1 
ref #2318
@shaman-apprentice
fix: use real color metric min value and clean up redundant data
a5f9e25 
ref #2318
@shaman-apprentice
refactor: adjust tests to deriving color range min and max values fro…
5486ba5 
…m node metric data

instead of from store

ref #2318
@shaman-apprentice shaman-apprentice marked this pull request as ready for review May 14, 2022 19:20
shaman-apprentice
shaman-apprentice commented May 15, 2022
View reviewed changes
...ngsPanel/metricColorRangeSlider/rangeSlider/rangeSliderLabels/rangeSliderLabels.component.ts

ngAfterViewChecked(): void {
if (this.hasUnhandledChanges) {
// There is somewhere a bug, that it get rendered with 0 width shortly. Maybe a bug with AngularJS dual booting?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a clean up task to #2318 to invest into it after full migration.

@shaman-apprentice shaman-apprentice force-pushed the refactor/2318/migrate-range-slider-component branch from 29ce2f3 to 1f95ead Compare May 15, 2022 10:33
luelista
luelista approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@luelista luelista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some small changes to variable names and moved the selectors from metricColorRangeSlider/rangeSlider/selectors up one directory to metricColorRangeSlider/selectors.

@luelista luelista force-pushed the refactor/2318/migrate-range-slider-component branch from aef52bc to 8581cf4 Compare May 17, 2022 10:20
@sonarcloud
Copy link

sonarcloud bot commented May 17, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 17, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

93.3% 93.3% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit 9ecb9fc into main May 17, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-range-slider-component branch May 17, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luelista luelista luelista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@shaman-apprentice @luelista