Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: migrate center-map-button #2809

Merged
merged 2 commits into from May 18, 2022
Merged

refactor: migrate center-map-button #2809

merged 2 commits into from May 18, 2022

Conversation

shaman-apprentice
Copy link
Contributor

ref #2318

@sonarcloud
Copy link

sonarcloud bot commented May 17, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 17, 2022

[CodeCharta Visualization] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

69.2% 69.2% Coverage
0.0% 0.0% Duplication

@shaman-apprentice
Copy link
Contributor Author

By tests uncovered code are 4 lines of pure Angular boiler code.

@shaman-apprentice shaman-apprentice merged commit fdd6f4a into main May 18, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-center-map-button branch May 18, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hall-Ma Hall-Ma Hall-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shaman-apprentice @Hall-Ma