Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/2318/migrate distribution metric chooser #2824

Merged

Conversation

shaman-apprentice
Copy link
Contributor

migrate distribution chooser and distributionMetric.service

ref #2318

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.7% 90.7% Coverage
0.0% 0.0% Duplication

Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@IhsenBouallegue
Copy link
Collaborator

Quick question. Why is the old AngularJS metricChooser deprecated but still present? Are we unable to remove it completely?

@shaman-apprentice
Copy link
Contributor Author

Quick question. Why is the old AngularJS metricChooser deprecated but still present? Are we unable to remove it completely?

the metricChooserController was host of the distribution metric chooser and is still host of the area, height and color metric chooser

@shaman-apprentice shaman-apprentice merged commit 82209aa into main May 27, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-distribution-metric-chooser branch May 27, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants