New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/2318/migrate distribution metric chooser #2824
Refactor/2318/migrate distribution metric chooser #2824
Conversation
…-distribution-metric-chooser
so we can introduce Angular MetricChooser at its place ref #2318
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Quick question. Why is the old AngularJS metricChooser deprecated but still present? Are we unable to remove it completely? |
the metricChooserController was host of the distribution metric chooser and is still host of the area, height and color metric chooser |
migrate distribution chooser and distributionMetric.service
ref #2318