Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2856/action icon #2857

Merged
merged 10 commits into from Jun 24, 2022
Merged

Fix/2856/action icon #2857

merged 10 commits into from Jun 24, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Jun 19, 2022

close #2856, ref #2318

@shaman-apprentice shaman-apprentice marked this pull request as ready for review June 20, 2022 06:00
@shaman-apprentice
Copy link
Contributor Author

Changelog is still missing. Will add depending on chosen Icon

# Conflicts:
#	visualization/app/app.module.ts
Copy link
Collaborator

@IhsenBouallegue IhsenBouallegue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM🥇

@jannikr jannikr self-requested a review June 22, 2022 13:34
Copy link
Contributor

@jannikr jannikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the Mac too!

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit 9801cd3 into main Jun 24, 2022
@shaman-apprentice shaman-apprentice deleted the fix/2856/action-icon branch June 24, 2022 12:47
@ce-bo ce-bo mentioned this pull request Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify UI of action icons in toolbar
3 participants