Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/2318/migrate color settings panel #2873

Merged
merged 6 commits into from Jul 1, 2022
Merged

Refactor/2318/migrate color settings panel #2873

merged 6 commits into from Jul 1, 2022

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Jun 29, 2022 •
edited

This PR does:

@shaman-apprentice
Copy link
Contributor Author

I noticed a small bug, which is already in current version (#2874). I likely introduced it in a previous PR and will fix it in a separate PR.

Chrisp485
Chrisp485 reviewed Jun 30, 2022
View reviewed changes
Copy link
Contributor

@Chrisp485 Chrisp485 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shaman-apprentice When in Delta Mode, and you change the colors and afterwards want to reset to default, only the selected color gets reset. Positive + negative delta dont get reset.
delta_color_reset

@shaman-apprentice
Copy link
Contributor Author

@shaman-apprentice When in Delta Mode, and you change the colors and afterwards want to reset to default, only the selected color gets reset. Positive + negative delta dont get reset. delta_color_reset

Thanks, good catch! Although this is a bug not related to the migration. I just created #2876 and fixed it within this migration PR.

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.3% 95.3% Coverage
0.0% 0.0% Duplication

Chrisp485
Chrisp485 approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@Chrisp485 Chrisp485 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, bug is fixed thanks 👍

@Chrisp485 Chrisp485 merged commit 7831516 into main Jul 1, 2022
@Chrisp485 Chrisp485 deleted the refactor/2318/migrate-color-settings-panel branch July 1, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chrisp485 Chrisp485 Chrisp485 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reset colors in delta mode doesn't work
2 participants
@shaman-apprentice @Chrisp485