Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify build_gh_pages.sh in order to create zipped maps for pipeline … #2915

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Modify build_gh_pages.sh in order to create zipped maps for pipeline … #2915

merged 3 commits into from
Jul 27, 2022

Conversation

jannikr
Copy link
Contributor

@jannikr jannikr commented Jul 27, 2022

Create zipped maps in pipeline build

Issue: #2538

We would like to test this modification with a patch release.

@MW-Friedrich MW-Friedrich linked an issue Jul 27, 2022 that may be closed by this pull request
Create zipped CodeCharta cc.json files during pipeline build #2538
Closed
@MW-Friedrich
Copy link
Contributor

MW-Friedrich commented Jul 27, 2022 •
edited

If @ce-bo is alright with this, we could merge and release #2913 as a patch to test this? 🤔

ce-bo
ce-bo reviewed Jul 27, 2022
View reviewed changes
script/build_gh_pages.sh
@@ -22,12 +22,16 @@ $CCSH sonarimport -nc -o codecharta_sonar.cc.json https://sonarcloud.io maibornw
$CCSH modify --set-root root/maibornwolff-gmbh_codecharta_visualization -o codecharta_sonar_mod.cc.json codecharta_sonar.cc.json

$CCSH merge -o ../visualization/app/codecharta.cc.json codecharta_sonar_mod.cc.json codecharta_git_mod.cc.json -nc
# Zipped map for pipeline build
$CCSH merge -o ../visualization/app/codecharta.cc.json codecharta_sonar_mod.cc.json codecharta_git_mod.cc.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$CCSH merge -o ../visualization/app/codecharta.cc.json codecharta_sonar_mod.cc.json codecharta_git_mod.cc.json
$CCSH merge -o ../visualization/app/codecharta.cc.json.gz codecharta_sonar_mod.cc.json codecharta_git_mod.cc.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried your suggestion and we don't need it. The merge filter puts .gz at the end automatically.

@Hall-Ma
Copy link
Contributor

Hall-Ma commented Jul 27, 2022

If @ce-bo is alright with this, we could merge and release #2913 as a patch to test this? 🤔

Yesterday Cedrik and I discussed this topic. We will release it as a patch.

ce-bo
ce-bo reviewed Jul 27, 2022
View reviewed changes
script/build_gh_pages.sh
$CCSH modify --set-root root/maibornwolff-gmbh_codecharta_analysis -o codecharta_sonar_mod.cc.json codecharta_sonar_analysis.cc.json
$CCSH modify --set-root root/analysis -o codecharta_git_mod.cc.json codecharta_git.cc.json
$CCSH merge -o ../visualization/app/codecharta_analysis.cc.json codecharta_sonar_mod.cc.json codecharta_git_mod.cc.json -nc
# Zipped map for pipeline build
$CCSH merge -o ../visualization/app/codecharta_analysis.cc.json codecharta_sonar_mod.cc.json codecharta_git_mod.cc.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$CCSH merge -o ../visualization/app/codecharta_analysis.cc.json codecharta_sonar_mod.cc.json codecharta_git_mod.cc.json
$CCSH merge -o ../visualization/app/codecharta_analysis.cc.json.gz codecharta_sonar_mod.cc.json codecharta_git_mod.cc.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried your suggestion and we don't need it. The merge filter puts .gz at the end automatically.

ce-bo
ce-bo reviewed Jul 27, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did zippedMap.cc.json.gz was added intentionally?
Let's add a changelog entry, so that the users know the reason for the upcoming patch release.

@jannikr
Copy link
Contributor Author

jannikr commented Jul 27, 2022

Did zippedMap.cc.json.gz was added intentionally? Let's add a changelog entry, so that the users know the reason for the upcoming patch release.

Yes, we did this for testing purposes, as a second approach to read zipped files.

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jannikr jannikr merged commit 38761c1 into main Jul 27, 2022
@jannikr jannikr deleted the tech/2538/generate-unzipped-and-zipped-files-in-pipeline branch July 27, 2022 08:49
@MW-Friedrich MW-Friedrich mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo left review comments

@Hall-Ma Hall-Ma Hall-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create zipped CodeCharta cc.json files during pipeline build
4 participants
@jannikr @MW-Friedrich @Hall-Ma @ce-bo