Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interactive usage of SonarImporter #2913

Merged
merged 5 commits into from Jul 27, 2022

Conversation

MW-Friedrich
Copy link
Contributor

@MW-Friedrich MW-Friedrich commented Jul 26, 2022

Fix interactive usage of SonarImporter

Issue: #2861

Description

When no list of metrics is supplied in the interactive usage of the ccsh, the corresponding command (and therefore the request url) contains "--metrics=" instead of omitting the flag and selecting all metrics. Same with the --user flag.

Screenshots or gifs

@MW-Friedrich MW-Friedrich changed the title Add a test, so that if "metrics" are empty, there is no flag in the cli Fix interactive usage of SonarImporter Jul 26, 2022
@MW-Friedrich MW-Friedrich marked this pull request as ready for review July 27, 2022 07:38
@MW-Friedrich MW-Friedrich linked an issue Jul 27, 2022 that may be closed by this pull request
Copy link
Contributor

@Chrisp485 Chrisp485 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it and works again!

@MW-Friedrich
Copy link
Contributor Author

@knoffi and I will merge this after the patch release from #2915 :)

@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MW-Friedrich MW-Friedrich enabled auto-merge (squash) July 27, 2022 11:32
@sonarcloud
Copy link

sonarcloud bot commented Jul 27, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive usage of SonarImporter is failing
2 participants