Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/2318/migrate artificial intelligence component #2997

Merged

Conversation

shaman-apprentice
Copy link
Contributor

@shaman-apprentice shaman-apprentice commented Aug 27, 2022

fix #3031
ref #2318

Copy link
Contributor Author

@shaman-apprentice shaman-apprentice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo:

  • add changelog

@ce-bo artificialIntelligence.component was basically implemented by you, wasn't it? Do you have time to for the review? I mainly split the two buttons into two components and did a little css adjustment due to Angular components.

@shaman-apprentice shaman-apprentice marked this pull request as ready for review August 27, 2022 11:35
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One minor remark: We could add some more spaces in between the three categories (suspicious, untracked, unsuspicious metrics). Furthermore, would you please check, why the red badge is not appearing after loading a new map? Thank you!

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.0% 97.0% Coverage
0.0% 0.0% Duplication

@shaman-apprentice shaman-apprentice merged commit 0c8cc45 into main Sep 11, 2022
@shaman-apprentice shaman-apprentice deleted the refactor/2318/migrate-artificial-intelligence-component branch September 11, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspicious metrics badge is only shown initially
2 participants