New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/2318/migrate artificial intelligence component #2997
Refactor/2318/migrate artificial intelligence component #2997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Todo:
- add changelog
@ce-bo artificialIntelligence.component was basically implemented by you, wasn't it? Do you have time to for the review? I mainly split the two buttons into two components and did a little css adjustment due to Angular components.
visualization/app/codeCharta/ui/artificialIntelligence/artificialIntelligence.component.html
Show resolved
Hide resolved
visualization/app/codeCharta/ui/artificialIntelligence/artificialIntelligence.component.html
Outdated
Show resolved
Hide resolved
...harta/ui/ribbonBar/artificialIntelligence/suspiciousMetrics/suspiciousMetrics.component.html
Show resolved
Hide resolved
…in/main' into refactor/2318/migrate-artificial-intelligence-component ref #2318
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One minor remark: We could add some more spaces in between the three categories (suspicious, untracked, unsuspicious metrics). Furthermore, would you please check, why the red badge is not appearing after loading a new map? Thank you!
[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed! |
[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed! |
fix #3031
ref #2318