Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3047/Uncheck-Checkbox-Invert-Height-Option #3048

Merged
merged 3 commits into from Sep 23, 2022
Merged

Fix/3047/Uncheck-Checkbox-Invert-Height-Option #3048

merged 3 commits into from Sep 23, 2022

Conversation

Hall-Ma
Copy link
Contributor

@Hall-Ma Hall-Ma commented Sep 23, 2022

Uncheck the box when the 'Invert height' option is clicked

Closes: #3047

Description

  • fix binding of observable that is responsible for checking and unchecking the box for 'invert height' option

@Hall-Ma Hall-Ma enabled auto-merge (squash) September 23, 2022 14:38
ce-bo
ce-bo reviewed Sep 23, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
ce-bo
ce-bo approved these changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@ce-bo ce-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a small remark though.

@Hall-Ma @ce-bo
Update CHANGELOG.md
3a522e2 
Co-authored-by: Cedrik Bormann <26900540+ce-bo@users.noreply.github.com>
@Hall-Ma Hall-Ma removed the request for review from MW-Friedrich September 23, 2022 15:02
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

[CodeCharta Analysis] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

[CodeCharta Visualization] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Hall-Ma Hall-Ma merged commit 6f312b8 into main Sep 23, 2022
@Hall-Ma Hall-Ma deleted the fix/3047/uncheck-checkbox-when-reset-invert-height branch September 23, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ce-bo ce-bo ce-bo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox doesn't reset when 'reset invert height' option is clicked (arrow-circle icon)
2 participants
@Hall-Ma @ce-bo