Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/3047/Uncheck-Checkbox-Invert-Height-Option #3048

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Fix/3047/Uncheck-Checkbox-Invert-Height-Option #3048

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd641ef
Fix binding of invert height observable
Hall-Ma Sep 23, 2022
bb69af6
add changelog
Hall-Ma Sep 23, 2022
3a522e2
Update CHANGELOG.md
Hall-Ma Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/)

### Fixed 🐞

- Uncheck the box when 'reset invert height' icon is
clicked [#3048](https://github.com/MaibornWolff/codecharta/pull/3048)
Hall-Ma marked this conversation as resolved.
Show resolved Hide resolved
- Update ReadMe and GitHub pages for MetricGardener [#3045](https://github.com/MaibornWolff/codecharta/pull/3045)

## [1.106.1] - 2022-09-20
Expand Down
4 changes: 3 additions & 1 deletion ...zation/app/codeCharta/ui/ribbonBar/heightSettingsPanel/heightSettingsPanel.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,9 @@
></cc-slider>

<div class="cc-height-settings-panel-row cc-height-settings-panel-reset-row">
<mat-checkbox *ngIf="!(isDeltaState$ | async)" [checked]="invertHeight" (change)="setInvertHeight($event)">Invert Height</mat-checkbox>
<mat-checkbox (change)="setInvertHeight($event)" *ngIf="!(isDeltaState$ | async)" [checked]="invertHeight$ | async">
Invert Height
</mat-checkbox>
<cc-reset-settings-button
[settingsKeys]="['appSettings.amountOfTopLabels', 'appSettings.scaling.y', 'appSettings.invertHeight']"
tooltip="Reset height metric settings to their defaults"
Expand Down